Fix bug where the dropdowns are only scrollable inside the toolbar #315

Merged
merged 1 commit into from Feb 6, 2017

Projects

None yet

3 participants

@AGS-
Member
AGS- commented Feb 6, 2017

githubgraphiqlscrollbug

@facebook-github-bot

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@@ -61,7 +61,7 @@
}
.graphiql-container .toolbar {
- overflow-x: auto;
+ overflow-x: visible;
@wincent
wincent Feb 6, 2017 Contributor

Seems reasonable, but isn't overflow: visible the default? (Not sure if it's cascading down here though, haven't checked).

@AGS-
AGS- Feb 6, 2017 Member

It's defaulting to scroll for some reason, so I think hard coding it would be the best option.

@wincent
wincent Feb 6, 2017 Contributor

Sounds fair.

@wincent wincent merged commit 99b61ba into graphql:master Feb 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@AGS-
Member
AGS- commented Feb 6, 2017

Thanks @wincent !

@AGS- AGS- deleted the AGS-:GraphiQlCssToolbarOverflowX branch Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment