First-pass at inline-field descriptions in doc-explorer #322

Open
wants to merge 12 commits into
from

Projects

None yet

4 participants

@joelgriffith
Contributor
joelgriffith commented Feb 9, 2017 edited

Wubalubadubdub! First pass at the old inline-field descriptions. There is an edge-case though, since the doc-explorer has a min-width of 300px. So when the explorer is <300px, the ellipsis gets lost. I'd hate to alter that behavior as it can introduce regressions elsewhere:

inline-field-desc

Addresses: #169

greenkeeper and others added some commits Feb 10, 2017
@greenkeeper greenkeeper chore(package): update flow-bin to version 0.39.0
dfe2a93
@wincent wincent Merge pull request #324 from graphql/greenkeeper/flow-bin-0.39.0
Update flow-bin to the latest version 🚀
0cc163e
@wincent wincent Freshen yarn.lock fedbc61
@greenkeeper greenkeeper chore(package): update jsdom to version 9.11.0
940067b
@wincent wincent Merge pull request #325 from graphql/greenkeeper/jsdom-9.11.0
Update jsdom to the latest version 🚀
d3db778
@wincent wincent Freshen yarn.lock 07cc80d
@AGS- AGS- Update address step in test/README.md 7c8aa74
@wincent wincent Merge pull request #326 from AGS-/UpdateTestReadme
Update address step in test/README.md
a02a76a
css/doc-explorer.css
+ color: #999;
+ white-space: nowrap;
+ text-overflow: ellipsis;
+ overflow: hidden;
@wincent
wincent Feb 13, 2017 Contributor

nit: would alphabetize this.

@wincent
Contributor
wincent commented Feb 13, 2017

Thanks!

This looks reasonable to me. I think that losing the ellipsis sub-300px is probably fine, as the UI already starts to truncate there intentionally anyway.

As this is a visual change, CC'ing @asiandrummer and @leebyron to take a look too. Code looks fine though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment