Skip to content

fix: correct validation diagnostic highlight range#4319

Open
cyphercodes wants to merge 1 commit into
graphql:mainfrom
cyphercodes:fix/graphql-language-service-validation-highlight-range
Open

fix: correct validation diagnostic highlight range#4319
cyphercodes wants to merge 1 commit into
graphql:mainfrom
cyphercodes:fix/graphql-language-service-validation-highlight-range

Conversation

@cyphercodes
Copy link
Copy Markdown

Summary

  • Fix validation diagnostic range end positions to use zero-based LSP offsets
  • Add regression coverage so invalid field highlights stop before trailing whitespace
  • Add a patch changeset for graphql-language-service

Fixes #4234.

Tests

  • yarn vitest run packages/graphql-language-service/src/interface/tests/getDiagnostics.test.ts
  • yarn tsgo --build packages/graphql-language-service/tsconfig.json
  • yarn vitest run packages/graphql-language-service/src
  • yarn turbo run test --filter=graphql-language-service
  • yarn turbo run types:check --filter=graphql-language-service
  • yarn oxfmt --check packages/graphql-language-service/src/interface/getDiagnostics.ts packages/graphql-language-service/src/interface/tests/getDiagnostics.test.ts .changeset/loud-fields-dance.md
  • git diff --check

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 23, 2026

🦋 Changeset detected

Latest commit: 2717712

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
graphql-language-service Patch
codemirror-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla
Copy link
Copy Markdown

CLA Not Signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[lsp-server] 🐞 Validation highlight offset

1 participant