From a81e6238fa3f3dd317cb33572dcc97020376c329 Mon Sep 17 00:00:00 2001 From: Yaacov Rydzinski Date: Thu, 21 Mar 2024 21:33:06 +0200 Subject: [PATCH] chore(benchmark): update v8 flag (#4029) changed in v8 11.3 / node 20 see: https://chromium.googlesource.com/v8/v8/+/73c45833472086ca1c6ab4140cdb058d1890e930%5E%21/src/flags/flag-definitions.h fixes benchmarking, see https://github.com/graphql/graphql-js/actions/runs/8314729475/job/22752257524#step:6:142 --- resources/benchmark.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/benchmark.ts b/resources/benchmark.ts index 2d7216c2b1..a03c619e04 100644 --- a/resources/benchmark.ts +++ b/resources/benchmark.ts @@ -404,7 +404,7 @@ function sampleModule(modulePath: string): BenchmarkSample { // V8 flags '--predictable', '--no-concurrent-sweeping', - '--no-scavenge-task', + '--no-minor-gc-task', '--min-semi-space-size=1024', // 1GB '--max-semi-space-size=1024', // 1GB '--trace-gc', // no gc calls should happen during benchmark, so trace them