Permalink
Commits on Feb 16, 2017
  1. Merge pull request #717 from wincent/glh/degrade-to-warn

    Soften name validation warnings to avoid CI issues
    wincent committed on GitHub Feb 16, 2017
  2. Note that failing dunderscore name validation will become a hard error

    To adequately serve as a deprecation warning, the message should provide
    advance notice that it non-compliance will eventually become a hard
    error. I haven't put a version number in there yet because I don't know
    which version it will happen in. Once we make that call we should make
    the message more precise.
    wincent committed Feb 16, 2017
  3. Avoid "Error:" text in advisory warnings

    This goes a step further than the parent commit, which downgrades
    `console.error` to `console.warn` for cases that are really just
    advisory "deprecation" warnings for non-compliant schemas.
    
    The motivation in that commit was preventing CI failures stemming from
    use of `console.error`.
    
    That may not be enough though, because on some JS engines (notably
    Chrome/Node), "Error: " still appears in the output thanks to our use of
    `Error` objects to get stack traces. Depending on how the CI is set-up,
    that could also be enough to spuriously fail the run.
    
    So in this commit, we add a `formatWarning` helper that takes the
    `Error` object and grooms it for use as a human-readable warning
    message.
    
    Added tests to capture and verify the different engine behaviors.
    wincent committed Feb 16, 2017
  4. Use console.warn in name validation

    In fe34619 we degraded the hard error (ie. a `throw`)
    for non-compliant field names (ie. starting with `__`) to a
    `console.error`.
    
    We've found, however, that certain CI systems will treat the use of
    `console.error` as a cause for failure, and our intent here is not to
    block what would otherwise be a valid test run.
    
    Switch to `console.warn` instead.
    
    Eventually in a later release this will become a hard error, but for now
    continuing to treat this like a "deprecation" and just warn is
    appropriate.
    wincent committed Feb 16, 2017
Commits on Feb 14, 2017
  1. Freshen yarn.lock

    wincent committed Feb 14, 2017
  2. Merge pull request #714 from graphql/greenkeeper/babel-plugin-transfo…

    …rm-object-rest-spread-6.23.0
    
    Update babel-plugin-transform-object-rest-spread to the latest version 🚀
    wincent committed on GitHub Feb 14, 2017
  3. Merge pull request #713 from graphql/greenkeeper/babel-plugin-transfo…

    …rm-es2015-destructuring-6.23.0
    
    Update babel-plugin-transform-es2015-destructuring to the latest version 🚀
    wincent committed on GitHub Feb 14, 2017
Commits on Feb 11, 2017
  1. Freshen yarn.lock

    wincent committed Feb 11, 2017
  2. Merge pull request #712 from graphql/greenkeeper/flow-bin-0.39.0

    Update flow-bin to the latest version 🚀
    wincent committed on GitHub Feb 11, 2017
Commits on Feb 9, 2017
  1. Correct a code comment

    Description got stale over the evolution of the PR:
    
    #701
    wincent committed Feb 9, 2017
Commits on Feb 5, 2017
  1. Freshen yarn.lock

    wincent committed Feb 5, 2017
Commits on Feb 3, 2017
  1. Freshen yarn.lock

    wincent committed Feb 3, 2017
  2. Merge pull request #705 from graphql/greenkeeper/eslint-3.15.0

    Update eslint to the latest version 🚀
    wincent committed on GitHub Feb 3, 2017