Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visitor does not support `enter` and `leave` for the root node #298

Merged
merged 2 commits into from Feb 23, 2016

Conversation

Projects
None yet
3 participants
@dminkovsky
Copy link
Contributor

commented Feb 20, 2016

Opening an issue to discuss this apparent problem.

@dminkovsky

This comment has been minimized.

Copy link
Contributor Author

commented Feb 20, 2016

Added a proposed fix.

@leebyron

This comment has been minimized.

Copy link
Collaborator

commented Feb 20, 2016

Thanks so much for detecting and investigating a fix. I'll investigate to add some confidence to the fix, but from first look it appears good.

@dminkovsky dminkovsky force-pushed the dminkovsky:visitor-edit-root-node branch from e42e53a to f79ba42 Feb 21, 2016

@dminkovsky

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2016

Thanks Lee. This visitor is really useful.

@leebyron leebyron merged commit f79ba42 into graphql:master Feb 23, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 99.379%
Details

sogko added a commit to sogko/graphql that referenced this pull request Mar 11, 2016

Proposed fix
Commit:
f79ba42e30d9f1380f378440e4fe66b1aa428386 [f79ba42]
Parents:
4256230557
Author:
Dmitry Minkovsky <dminkovsky@gmail.com>
Date:
21 February 2016 at 6:03:39 AM SGT
Commit Date:
21 February 2016 at 12:06:22 PM SGT

---

Tests to demonstrate problem

Commit:
42562305570b04a5b7ec1ee7714f020f366023c9 [4256230]
Parents:
75e7be0028
Author:
Dmitry Minkovsky <dminkovsky@gmail.com>
Date:
21 February 2016 at 5:40:46 AM SGT
Commit Date:
21 February 2016 at 12:06:07 PM SGT

---

Note: See PR graphql-go#298 for context: graphql/graphql-js#298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.