From 6e7ba2735fdef96b25bcdc77b9c97aa7b2eb7e20 Mon Sep 17 00:00:00 2001 From: andimarek Date: Thu, 16 Jul 2015 02:23:20 +0200 Subject: [PATCH] use isCompositeType function instead of manual checking --- src/validator/rules/FragmentsOnCompositeTypes.js | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/validator/rules/FragmentsOnCompositeTypes.js b/src/validator/rules/FragmentsOnCompositeTypes.js index a5721e6514..945fdbc010 100644 --- a/src/validator/rules/FragmentsOnCompositeTypes.js +++ b/src/validator/rules/FragmentsOnCompositeTypes.js @@ -12,9 +12,7 @@ import type { ValidationContext } from '../index'; import { GraphQLError } from '../../error'; import { - GraphQLObjectType, - GraphQLInterfaceType, - GraphQLUnionType + isCompositeType } from '../../type/definition'; import { fragmentOnNonCompositeErrorMessage } from '../errors'; @@ -33,11 +31,7 @@ export default function FragmentsOnCompositeType( InlineFragment(node) { var typeName = node.typeCondition.value; var type = context.getSchema().getType(typeName); - var isCompositeType = - type instanceof GraphQLObjectType || - type instanceof GraphQLInterfaceType || - type instanceof GraphQLUnionType; - if (!isCompositeType) { + if (!isCompositeType(type)) { return new GraphQLError( `Fragment cannot condition on non composite type "${typeName}".`, [node.typeCondition] @@ -47,11 +41,7 @@ export default function FragmentsOnCompositeType( FragmentDefinition(node) { var typeName = node.typeCondition.value; var type = context.getSchema().getType(typeName); - var isCompositeType = - type instanceof GraphQLObjectType || - type instanceof GraphQLInterfaceType || - type instanceof GraphQLUnionType; - if (!isCompositeType) { + if (!isCompositeType(type)) { return new GraphQLError( fragmentOnNonCompositeErrorMessage(node.name.value, typeName), [node.typeCondition]