This repository has been archived by the owner on Sep 2, 2020. It is now read-only.
Make watchman dependency optional #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
February 16, 2018 07:48
Also abstracted watchman initialization logic out of MessageProcess.handleInitializeRequest and into a separate instance method. In order to facilitate the use of MockWatchmanClient in tests, a GraphQLWatchman-shaped object is now passed into the MessageProcessor constructor.
|
@mgadda let's add the non-related files as separate PR(s) please. |
|
@asiandrummer if you're referring to my comments about |
|
Thanks @mgadda ! |
|
@mgadda - apologies again for a huge delay. I'd love to establish a different primary contact mean from emailing - apparently I suck at reading them 😢 |
|
@asiandrummer I've sent you a message on Facebook Messenger if that's preferable. It's probably hiding in the people-you-don't-know inbox. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch, which addresses issue #206, makes watchman an optional dependency of graphql-language-service. The motivation for this patch is defined within the language server specification under DidChangeWatchedFiles Notification. Less dependencies make for easier administration of IDEs that rely on graphql-language-service.
That said, it's conceivable that many consumers of this project already rely and/or prefer to use watchman instead of LSP for file watch events. To appease both use cases, this PR leaves full watchman support intact and functional by default. Only if watchman is not detected on the system will LSP be used for watched file change events.
In order to facilitate the two separate mechanisms for being notified of watched file change events,
GraphQLWatchmanhas been decoupled fromGraphQLCache. It is now a caller or consumer of GraphQLCache rather than a dependent class. This means thatGraphQLWatchman.listFiles()has been replaced byglob()whenGraphQLCachewants to obtain a list of files to parse and cache.Watchman subscription is now handled within
MessageProcessor.handleInitializeRequestand in turn_subcribeWatchman.Finally, while the diff looks fairly large, it's mostly the same code you already know just moving around a bit.