New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature go to definition SDL - input, enum, type #237

Merged
merged 8 commits into from Jun 3, 2018

Conversation

Projects
None yet
2 participants
@divyenduz
Contributor

divyenduz commented Jun 2, 2018

  1. Implement go to definition for input, enum, type in SDL with some test cases

  2. Support live file reload

  3. Fixes a related test case in getDefinition that was found while implementing this part of code i.e. I think it belongs here

Thanks! :)

@asiandrummer

Approving to unblock. I haven't gone through the entire PR yet, so I might be coming back later and making some comments.

README.md Outdated
@@ -14,6 +14,7 @@ Currently supported features include:
- Diagnostics (GraphQL syntax linting/validations) (**spec-compliant**)
- Autocomplete suggestions (**spec-compliant**)
- Hyperlink to fragment definitions (**spec-compliant**)
- Hyperlink to named types (type, input, enum) definitions (**spec-compliant**)

This comment has been minimized.

@asiandrummer

asiandrummer Jun 2, 2018

Contributor

Lets just merge it above:

Hyperlink to fragment and named types (type, input, enum) definitions 

This comment has been minimized.

@divyenduz

divyenduz Jun 3, 2018

Contributor

Done.

@asiandrummer asiandrummer merged commit cc6b063 into graphql:master Jun 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schickling schickling referenced this pull request Jun 4, 2018

Merged

Released v1.2 #238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment