Cut CharacterStream circular dependency #37

Merged
merged 1 commit into from Feb 15, 2017

Projects

None yet

1 participant

@wincent
Contributor
wincent commented Feb 15, 2017

Another step towards breaking this out into packages: move the CharacterStream type into types/Types.js as an interface. Requires switching to property syntax to avoid some Flow complaints about covariance vs invariance.

With this change, Types has no dependencies inside of the languageservice, which means we can extract it.

Bonus along the way: shortened some simple methods into one liners, seeing as we have arrow functions and single expressions, so we may as well just return the expression directly.

@wincent wincent Cut CharacterStream circular dependency
Another step towards breaking this out into packages: move the
`CharacterStream` type into `types/Types.js` as an interface. Requires
switching to property syntax to avoid some Flow complaints about
covariance vs invariance.

With this change, `Types` has no dependencies inside of the language
service, which means we can extract it.

Bonus along the way: shortened some simple methods into one liners,
seeing as we have arrow functions and single expressions, so we may as
well just return the expression directly.
17e93f0
@wincent wincent merged commit 9839467 into graphql:master Feb 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wincent wincent deleted the wincent:glh/char-stream branch Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment