Expose offsetToCursor method
#37
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already export a `cursorForObjectInConnection` method which itself calls `offsetToCursor`, but because it relies internally on `Array.prototype.indexOf` to derive the offset, it is not well suited for use cases where objects may be equivalent but not strictly equal (`===`). By exporting `offsetToCursor`, schema authors can derive cursors on their own without having to go through `cursorForObjectInConnection`. This mirrors what we do with `cursorToOffset`, which is already exported. Fixes: #29
steveluscher
added a commit
that referenced
this pull request
Oct 23, 2015
Expose `offsetToCursor` method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already export a
cursorForObjectInConnectionmethod which itself callsoffsetToCursor, but because it relies internally onArray.prototype.indexOfto derive the offset, it is not well suited for use cases where objects may be equivalent but not strictly equal (===).By exporting
offsetToCursor, schema authors can derive cursors on their own without having to go throughcursorForObjectInConnection. This mirrors what we do withcursorToOffset, which is already exported.Fixes: #29