From 8887b7a92fcc4f228b503daaf2681a17839f6d40 Mon Sep 17 00:00:00 2001
From: Jeremy Benoist <jeremy.benoist@gmail.com>
Date: Tue, 23 Aug 2016 22:49:56 +0200
Subject: [PATCH] Make RSS valid

Validation failed with the previous feed (even if I checked it ..)

This feed does not validate.

    line 1, column 38: Missing namespace for feed [help]
    <?xml version="1.0" encoding="utf-8"?><feed><title>Blog |
GraphQL</title><li ...
                                          ^
    line 1, column 112: Missing feed element: id [help]
    ... ><link href="http://graphql.org/blog/"/><entry><title>Wrapping a
REST AP ...
                                                 ^
    line 1, column 112: Missing feed element: updated [help]
    ... ><link href="http://graphql.org/blog/"/><entry><title>Wrapping a
REST AP ...
                                                 ^
    line 1, column 263: id must be a full and valid URL:
/blog/rest-api-graphql-wrapper/ (4 occurrences) [help]
    ...
r/"/><id>/blog/rest-api-graphql-wrapper/</id><updated>2016-05-05T00:00:0
...
---
 resources/renderReactPage.js | 3 +++
 site/blog/rss.xml.js         | 6 ++++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/resources/renderReactPage.js b/resources/renderReactPage.js
index 461c7f9a3d..04c2285b34 100644
--- a/resources/renderReactPage.js
+++ b/resources/renderReactPage.js
@@ -24,6 +24,9 @@ function renderReactPage(options) {
   var html = React.renderToStaticMarkup(React.createElement(component, props));
 
   if (html.indexOf('<feed') !== -1) {
+    // react remove namespace so we re-add manually
+    html = html.replace('<feed>', '<feed xmlns="http://www.w3.org/2005/Atom">');
+
     return '<?xml version="1.0" encoding="utf-8"?>' + html;
   }
 
diff --git a/site/blog/rss.xml.js b/site/blog/rss.xml.js
index 7fe34c2141..f70d10a12c 100644
--- a/site/blog/rss.xml.js
+++ b/site/blog/rss.xml.js
@@ -16,15 +16,17 @@ var BlogRss = React.createClass({
       .filter(file => !file.draft && path.extname(file.relPath) === '.md')
       .sort((a, b) => a.date < b.date);
     return (
-      <feed xmlns="http://www.w3.org/2005/Atom">
+      <feed>
         <title>Blog | GraphQL</title>
         <link href="http://graphql.org/blog/"/>
+        <id>http://graphql.org/blog/</id>
+        <updated>{new Date(posts[0].date).toISOString()}</updated>
 
         {posts.map(post =>
           <entry>
             <title>{post.title}</title>
             <link href={'http://graphql.org' + post.url}/>
-            <id>{post.permalink}</id>
+            <id>http://graphql.org{post.url}</id>
             <updated>{new Date(post.date).toISOString()}</updated>
             <summary>{post.title}</summary>
             <content>{post.title}</content>