New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tutorial-Authentication.md #648

Open
wants to merge 1 commit into
base: source
from

Conversation

Projects
None yet
2 participants
@joelcolucci
Copy link

joelcolucci commented Jan 22, 2019

Background

The current GraphQL Authentication and Express Middleware documentation states the "request" object is passed as the second argument in a resolver.

However, the express-graphql (v0.7.1 ) documentation states the "request" object is passed as the third argument to resolvers. See here: https://github.com/graphql/express-graphql#combining-with-other-express-middleware

I've tested this and it appears the express-graphql documentation is correct.

Proposed File Change

I've updated this page to match the express-graphql documentation.

Please let me know if you have any questions.

Update Tutorial-Authentication.md
## Background 
The current GraphQL Authentication and Express Middleware documentation states the "request" object is passed as the second argument in a resolver.

However, the express-graphql (v0.7.1 ) documentation states the "request" object is passed as the third argument to resolvers. See here: https://github.com/graphql/express-graphql#combining-with-other-express-middleware

I've tested this and it appears the express-graphql documentation is correct.

## Proposed File Change
I've updated this page to match the express-graphql documentation.

Please let me know if you have any questions.
@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Jan 22, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Jan 22, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment