This repository has been archived by the owner. It is now read-only.

change the visual design of gittip #66

Closed
chadwhitacre opened this Issue Jun 19, 2012 · 67 comments

Comments

Projects
None yet
@chadwhitacre
Contributor

chadwhitacre commented Jun 19, 2012

Scroll down for comps.

@timothyfcook

This comment has been minimized.

Show comment
Hide comment
@timothyfcook

timothyfcook Jun 25, 2012

Contributor

I think the initial goal here should be creating 2 Gittip logos, large and button-sized.

Contributor

timothyfcook commented Jun 25, 2012

I think the initial goal here should be creating 2 Gittip logos, large and button-sized.

@timothyfcook

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jun 26, 2012

Contributor

You don't like the heart-coin favicon? :-)

Contributor

chadwhitacre commented Jun 26, 2012

You don't like the heart-coin favicon? :-)

@timothyfcook

This comment has been minimized.

Show comment
Hide comment
@timothyfcook

timothyfcook Jun 26, 2012

Contributor

nope.

Contributor

timothyfcook commented Jun 26, 2012

nope.

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jun 29, 2012

Contributor

Thanks for the effort. I think the design is good enough for the current phase of growth. My ideal would be to "hire" a professional designer to own the Gittip visual design for the next phase of growth (whatever "hiring" turns out to look like for an open corporation ;-) ).

I'm going to keep this ticket in the icebox for now.

Contributor

chadwhitacre commented Jun 29, 2012

Thanks for the effort. I think the design is good enough for the current phase of growth. My ideal would be to "hire" a professional designer to own the Gittip visual design for the next phase of growth (whatever "hiring" turns out to look like for an open corporation ;-) ).

I'm going to keep this ticket in the icebox for now.

@timothyfcook

This comment has been minimized.

Show comment
Hide comment
@timothyfcook

timothyfcook Jun 29, 2012

Contributor

I fully agree.

Contributor

timothyfcook commented Jun 29, 2012

I fully agree.

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jul 9, 2012

Contributor

For lack of more specifics, I interpret comments like this as +1's for this ticket.

Contributor

chadwhitacre commented Jul 9, 2012

For lack of more specifics, I interpret comments like this as +1's for this ticket.

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jul 25, 2012

Contributor

A few notes on this as I believe Damon from Balanced is going to give this some attention:

  • show data and comparisons
  • need data above the fold on the homepage
  • primary emphasis should be on receivers -- how are they making the world better? what's their story?
  • secondary emphasis should be on givers
  • work with funding goal (see also #147, though don't feel constrained to take it literally)
  • design should be responsive -- work on laptop at different resolutions and on mobile (phone and tablet)
  • current font is Lato, but it is problematic on Linux (#140) and in extended charsets (#62)
  • if you want to change the identity system let's tackle that first
Contributor

chadwhitacre commented Jul 25, 2012

A few notes on this as I believe Damon from Balanced is going to give this some attention:

  • show data and comparisons
  • need data above the fold on the homepage
  • primary emphasis should be on receivers -- how are they making the world better? what's their story?
  • secondary emphasis should be on givers
  • work with funding goal (see also #147, though don't feel constrained to take it literally)
  • design should be responsive -- work on laptop at different resolutions and on mobile (phone and tablet)
  • current font is Lato, but it is problematic on Linux (#140) and in extended charsets (#62)
  • if you want to change the identity system let's tackle that first
@sbaney

This comment has been minimized.

Show comment
Hide comment
@sbaney

sbaney Jul 25, 2012

I like the current design.

The icon is nice, but you may want to tweak the heart a bit - it looks a little squished to me.

I might also suggest a different color scheme. The neutral colors are relaxing but you might want something a little brighter.

Maybe a browse option of some sort would be helpful? Perhaps associating users with their projects (or primary/most recent project?) more readily?

sbaney commented Jul 25, 2012

I like the current design.

The icon is nice, but you may want to tweak the heart a bit - it looks a little squished to me.

I might also suggest a different color scheme. The neutral colors are relaxing but you might want something a little brighter.

Maybe a browse option of some sort would be helpful? Perhaps associating users with their projects (or primary/most recent project?) more readily?

@dmdj03

This comment has been minimized.

Show comment
Hide comment
@dmdj03

dmdj03 Jul 26, 2012

Would love everyone's feedback on the design for Gittip. Thanks!

https://www.dropbox.com/sh/k7gobwgqbttywo1/XngrL8lg6c [Scroll down! —ed.]

dmdj03 commented Jul 26, 2012

Would love everyone's feedback on the design for Gittip. Thanks!

https://www.dropbox.com/sh/k7gobwgqbttywo1/XngrL8lg6c [Scroll down! —ed.]

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jul 26, 2012

Contributor

This is really exciting, @dmdj03, thank you! Will review more fully tomorrow.

Contributor

chadwhitacre commented Jul 26, 2012

This is really exciting, @dmdj03, thank you! Will review more fully tomorrow.

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jul 26, 2012

Contributor

One quick question: could you post a bigger pic of the logo for us, and maybe say a few words about it?

Contributor

chadwhitacre commented Jul 26, 2012

One quick question: could you post a bigger pic of the logo for us, and maybe say a few words about it?

@dmdj03

This comment has been minimized.

Show comment
Hide comment
@dmdj03

dmdj03 Jul 26, 2012

Sure. You can use this same link to access the logo:
https://www.dropbox.com/sh/k7gobwgqbttywo1/XngrL8lg6c [Scroll down! —ed.]

With the logo, I wanted to create a separate bug that could be used independent of the wordmark - as a button perhaps. I modified the "G" to incorporate a bow/ribbon as a subtle reference to the idea of gifting / giving thanks.

dmdj03 commented Jul 26, 2012

Sure. You can use this same link to access the logo:
https://www.dropbox.com/sh/k7gobwgqbttywo1/XngrL8lg6c [Scroll down! —ed.]

With the logo, I wanted to create a separate bug that could be used independent of the wordmark - as a button perhaps. I modified the "G" to incorporate a bow/ribbon as a subtle reference to the idea of gifting / giving thanks.

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
Contributor

kennethreitz commented Jul 26, 2012

one


two


three


four

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz Jul 26, 2012

Contributor

Inline images ftw :)

Contributor

kennethreitz commented Jul 26, 2012

Inline images ftw :)

@chmullig

This comment has been minimized.

Show comment
Hide comment
@chmullig

chmullig Jul 26, 2012

I really like the bow/ribbon, because it looks a bit like an infinity sign, which implies the ongoing nature of donations. (Of course I'm in the middle of a math class right now, so me seeing infinity signs everywhere may be unusual).

I really like the bow/ribbon, because it looks a bit like an infinity sign, which implies the ongoing nature of donations. (Of course I'm in the middle of a math class right now, so me seeing infinity signs everywhere may be unusual).

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jul 26, 2012

Contributor

@dmdj03 Ah, now I see the bow, not sure what that was. Very cool!

@kennethreitz Thank you!

@chmullig Good call!

Contributor

chadwhitacre commented Jul 26, 2012

@dmdj03 Ah, now I see the bow, not sure what that was. Very cool!

@kennethreitz Thank you!

@chmullig Good call!

@timothyfcook

This comment has been minimized.

Show comment
Hide comment
@timothyfcook

timothyfcook Jul 26, 2012

Contributor

I like it. Although there was something nice and unique about the Green/Teal(?) color combination that Chad began with... I am partial to those colors, it's an attractive scheme that you don't see very often.

Contributor

timothyfcook commented Jul 26, 2012

I like it. Although there was something nice and unique about the Green/Teal(?) color combination that Chad began with... I am partial to those colors, it's an attractive scheme that you don't see very often.

@rchlmrtn

This comment has been minimized.

Show comment
Hide comment
@rchlmrtn

rchlmrtn Jul 26, 2012

Really a step up! The colors are a little bland, but still surprising...

Two verbal critiques:

  1. "Personal funding" is really vauge and not so inspiring. I would still like better something like "Put your money where your heart is," cheesy though it is.
  2. The two lines which start, "set up up recurring gift tips...." are way too long. Perhaps something like, "Give a recurring tip to people who (break) MAKE THE WORLD A BETTER PLACE." That way it's implied that both the person who is tipped and the person doing the tipping are "making the world a better place."

Really a step up! The colors are a little bland, but still surprising...

Two verbal critiques:

  1. "Personal funding" is really vauge and not so inspiring. I would still like better something like "Put your money where your heart is," cheesy though it is.
  2. The two lines which start, "set up up recurring gift tips...." are way too long. Perhaps something like, "Give a recurring tip to people who (break) MAKE THE WORLD A BETTER PLACE." That way it's implied that both the person who is tipped and the person doing the tipping are "making the world a better place."
@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jul 26, 2012

Contributor

Yeah I don't know. "Fund people"? "Fund people building the commons"? We lost the heart ...

Contributor

chadwhitacre commented Jul 26, 2012

Yeah I don't know. "Fund people"? "Fund people building the commons"? We lost the heart ...

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz Jul 26, 2012

Contributor

Sponsor People

Contributor

kennethreitz commented Jul 26, 2012

Sponsor People

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jul 26, 2012

Contributor

Does "fund" have currency at the moment? Crowd fund ing? Is that a hook?

Contributor

chadwhitacre commented Jul 26, 2012

Does "fund" have currency at the moment? Crowd fund ing? Is that a hook?

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jul 26, 2012

Contributor

I bought gfftd.com and reserved @gfftd on Twitter and GitHub. Do you think that name would work with @dmdj03's design?

Contributor

chadwhitacre commented Jul 26, 2012

I bought gfftd.com and reserved @gfftd on Twitter and GitHub. Do you think that name would work with @dmdj03's design?

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz Jul 26, 2012

Contributor

What's wrong with the current name that already has people's attention?

Contributor

kennethreitz commented Jul 26, 2012

What's wrong with the current name that already has people's attention?

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz Jul 26, 2012

Contributor

gittip is pronounceable and easy to remember. gfftd is not.

Contributor

kennethreitz commented Jul 26, 2012

gittip is pronounceable and easy to remember. gfftd is not.

@chmullig

This comment has been minimized.

Show comment
Hide comment
@chmullig

chmullig Jul 26, 2012

I can't even tell what letters are in gftftfd.

I can't even tell what letters are in gftftfd.

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jul 26, 2012

Contributor

It would be pronounced "gifted."

Contributor

chadwhitacre commented Jul 26, 2012

It would be pronounced "gifted."

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz Jul 26, 2012

Contributor

giftd

Contributor

kennethreitz commented Jul 26, 2012

giftd

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jul 26, 2012

Contributor

giftd

Checked, gone.

Contributor

chadwhitacre commented Jul 26, 2012

giftd

Checked, gone.

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz Jul 26, 2012

Contributor

FWIW though, I don't consider recurring payments to support someone a gift.

I do consider them a sponsorship though :)

Contributor

kennethreitz commented Jul 26, 2012

FWIW though, I don't consider recurring payments to support someone a gift.

I do consider them a sponsorship though :)

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jul 26, 2012

Contributor

Problems with the current name:

  • Gittip collides with GitHub
  • @gittip on Twitter is taken (though it sounds like he's willing to talk)
  • Tips aren't gifts.
  • Except in Australia.

gfftd can also refer to the person receiving the money. As in, "I sponsor @kenneithreitz because he's so gifted."

Contributor

chadwhitacre commented Jul 26, 2012

Problems with the current name:

  • Gittip collides with GitHub
  • @gittip on Twitter is taken (though it sounds like he's willing to talk)
  • Tips aren't gifts.
  • Except in Australia.

gfftd can also refer to the person receiving the money. As in, "I sponsor @kenneithreitz because he's so gifted."

@chmullig

This comment has been minimized.

Show comment
Hide comment
@chmullig

chmullig Jul 26, 2012

You want to be the verb, don't you? As in "I gittiped whit537 for helping me support myself."

You want to be the verb, don't you? As in "I gittiped whit537 for helping me support myself."

@rchlmrtn

This comment has been minimized.

Show comment
Hide comment
@rchlmrtn

rchlmrtn Jul 26, 2012

gifted doesn't have such a great vibe in my opinion...reminds me of middle school somehow.

gifted doesn't have such a great vibe in my opinion...reminds me of middle school somehow.

@rchlmrtn

This comment has been minimized.

Show comment
Hide comment

giftip?

@timothyfcook

This comment has been minimized.

Show comment
Hide comment
@timothyfcook

timothyfcook Jul 26, 2012

Contributor

I agree with those two critiques. "Personal Funding" is definitely vague.

"Fund people building the commons" is good.
"Fund people" is better than "Personal Funding" but keeps the brevity intact.

Other thoughts:
"Funding for the common do-gooder"
I kind of like "Genius grants for the rest of us"
"Common Funding"
"Support Good Work"

RIP heart favicon. Although I might like the "new" Gittip logo better if it was more of a Bow/Ribbon and less of an Infinity symbol... I'd be open to discussions bringing back the Heart logo though, it has grown on me.

Contributor

timothyfcook commented Jul 26, 2012

I agree with those two critiques. "Personal Funding" is definitely vague.

"Fund people building the commons" is good.
"Fund people" is better than "Personal Funding" but keeps the brevity intact.

Other thoughts:
"Funding for the common do-gooder"
I kind of like "Genius grants for the rest of us"
"Common Funding"
"Support Good Work"

RIP heart favicon. Although I might like the "new" Gittip logo better if it was more of a Bow/Ribbon and less of an Infinity symbol... I'd be open to discussions bringing back the Heart logo though, it has grown on me.

@timothyfcook

This comment has been minimized.

Show comment
Hide comment
@timothyfcook

timothyfcook Jul 26, 2012

Contributor

agreed about the "gifted" language, makes me think of the "gifted program" where the smart kids go, leaving the rest of us to fight over the 3 crayons left in the non-gifted kids art room.

Contributor

timothyfcook commented Jul 26, 2012

agreed about the "gifted" language, makes me think of the "gifted program" where the smart kids go, leaving the rest of us to fight over the 3 crayons left in the non-gifted kids art room.

@timothyfcook

This comment has been minimized.

Show comment
Hide comment
@timothyfcook

timothyfcook Jul 26, 2012

Contributor

Since we're brainstorming...

It's a bit weird, but what about this word:

grubstake   [gruhb-steyk] noun, verb, grub·staked, grub·stak·ing.

provisions, gear, etc., furnished to a prospector on condition of participating in the profits of any discoveries.
2.
money or other assistance furnished at a time of need or of starting an enterprise.

It's a super cool word, is very close to what we mean, and is generally un-used....I really like the definition of "participating in the profits of any discoveries"... because that's exactly the hope of our Tippers.

www.grubstake.com is owned by a guy who operates a small-time mountain lodge rental... I bet he'd be willing to sell or barter for the Domain and he could move to "www.grubstakelodge.com" ...you could barter him a new web design : )

Contributor

timothyfcook commented Jul 26, 2012

Since we're brainstorming...

It's a bit weird, but what about this word:

grubstake   [gruhb-steyk] noun, verb, grub·staked, grub·stak·ing.

provisions, gear, etc., furnished to a prospector on condition of participating in the profits of any discoveries.
2.
money or other assistance furnished at a time of need or of starting an enterprise.

It's a super cool word, is very close to what we mean, and is generally un-used....I really like the definition of "participating in the profits of any discoveries"... because that's exactly the hope of our Tippers.

www.grubstake.com is owned by a guy who operates a small-time mountain lodge rental... I bet he'd be willing to sell or barter for the Domain and he could move to "www.grubstakelodge.com" ...you could barter him a new web design : )

@chmullig

This comment has been minimized.

Show comment
Hide comment
@chmullig

chmullig Jul 26, 2012

I like it. I also bet that guy would take relatively little cash.

I like it. I also bet that guy would take relatively little cash.

@tomwolber

This comment has been minimized.

Show comment
Hide comment
@tomwolber

tomwolber Nov 27, 2012

What is the status of this design?

What is the status of this design?

@maximz

This comment has been minimized.

Show comment
Hide comment
@maximz

maximz Dec 5, 2012

Those Dropbox links don't work for me - are those files still available somewhere? Thanks!

maximz commented Dec 5, 2012

Those Dropbox links don't work for me - are those files still available somewhere? Thanks!

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jan 10, 2013

Contributor

@tomwolber The status of this design is that it is waiting for someone to love it. Gittip is hiring, and could really use a front-end person. Any recommendations? :-)

Contributor

chadwhitacre commented Jan 10, 2013

@tomwolber The status of this design is that it is waiting for someone to love it. Gittip is hiring, and could really use a front-end person. Any recommendations? :-)

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jan 10, 2013

Contributor

@maximz I thought I downloaded them but now I can't find them.

@dmdj03 Any chance you could upload those files here on this thread now that GitHub has added the attachments feature? Thanks! :-)

Contributor

chadwhitacre commented Jan 10, 2013

@maximz I thought I downloaded them but now I can't find them.

@dmdj03 Any chance you could upload those files here on this thread now that GitHub has added the attachments feature? Thanks! :-)

@dmdj03

This comment has been minimized.

Show comment
Hide comment
@dmdj03

dmdj03 Jan 10, 2013

@whit537 are you looking for the AI file? or just a jpg of the design?

dmdj03 commented Jan 10, 2013

@whit537 are you looking for the AI file? or just a jpg of the design?

@tehgeekmeister

This comment has been minimized.

Show comment
Hide comment
@tehgeekmeister

tehgeekmeister Jan 10, 2013

Contributor

@whit537 I may feel inspired to rework some of the front end to match that design once rubygems stuff is done, but one thing at a time.

Contributor

tehgeekmeister commented Jan 10, 2013

@whit537 I may feel inspired to rework some of the front end to match that design once rubygems stuff is done, but one thing at a time.

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jan 10, 2013

Contributor

@dmdj03 I was looking for the AI files.

Contributor

chadwhitacre commented Jan 10, 2013

@dmdj03 I was looking for the AI files.

@dmdj03

This comment has been minimized.

Show comment
Hide comment
@dmdj03

dmdj03 Jan 10, 2013

@whit537 I wasn't able to attach the AI here since it's not an image. Here's the link to the folder:

https://www.dropbox.com/sh/y939embdpcg80vz/lfFX6M_owb

dmdj03 commented Jan 10, 2013

@whit537 I wasn't able to attach the AI here since it's not an image. Here's the link to the folder:

https://www.dropbox.com/sh/y939embdpcg80vz/lfFX6M_owb

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jan 13, 2013

Contributor

Thanks @dmdj03! :-)

Contributor

chadwhitacre commented Jan 13, 2013

Thanks @dmdj03! :-)

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jan 13, 2013

Contributor

Whatever we do here needs to be responsive.

Contributor

chadwhitacre commented Jan 13, 2013

Whatever we do here needs to be responsive.

@clone1018

This comment has been minimized.

Show comment
Hide comment
@clone1018

clone1018 Jan 13, 2013

Contributor

I agree, also on another note looking into mobile apps wouldn't hurt in the future.

Contributor

clone1018 commented Jan 13, 2013

I agree, also on another note looking into mobile apps wouldn't hurt in the future.

@sigmavirus24

This comment has been minimized.

Show comment
Hide comment
@sigmavirus24

sigmavirus24 Jan 13, 2013

Contributor

@clone1018 as long as @whit537 only ever uses HTTPS, the mobile app (assuming it is well designed) will be the better way to go. Currently the API wouldn't allow for good mobile application development. (A RESTful API would make that way easier.)

Contributor

sigmavirus24 commented Jan 13, 2013

@clone1018 as long as @whit537 only ever uses HTTPS, the mobile app (assuming it is well designed) will be the better way to go. Currently the API wouldn't allow for good mobile application development. (A RESTful API would make that way easier.)

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jan 13, 2013

Contributor

Also, let's stick with the heart coin logo: .

Contributor

chadwhitacre commented Jan 13, 2013

Also, let's stick with the heart coin logo: .

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jan 13, 2013

Contributor

Mobile apps: Sure, just had a non-geek friend on Facebook ask me when to expect the iPhone app.

Contributor

chadwhitacre commented Jan 13, 2013

Mobile apps: Sure, just had a non-geek friend on Facebook ask me when to expect the iPhone app.

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jan 15, 2013

Contributor

@nicksergeant has expressed interest in picking this one up(!).

Contributor

chadwhitacre commented Jan 15, 2013

@nicksergeant has expressed interest in picking this one up(!).

@ghost ghost assigned nicksergeant Jan 16, 2013

@nicksergeant

This comment has been minimized.

Show comment
Hide comment
@nicksergeant

nicksergeant Jan 17, 2013

Contributor

Hopefully will be able to get started on the front-end by early next week. Looking forward to it :)

Contributor

nicksergeant commented Jan 17, 2013

Hopefully will be able to get started on the front-end by early next week. Looking forward to it :)

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jan 24, 2013

Contributor

@nicksergeant Reticketed conversion to markup as #516. Let's discuss further there and elsewhere.

Contributor

chadwhitacre commented Jan 24, 2013

@nicksergeant Reticketed conversion to markup as #516. Let's discuss further there and elsewhere.

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Jan 24, 2013

Contributor

At our hangout on Tuesday, we talked about using GitHub milestones more effectively, and I think this is a great case for that. I've created the following milestone to track this instead of continuing to load up this ticket with everything:

https://github.com/zetaweb/www.gittip.com/issues?milestone=26&state=open

Contributor

chadwhitacre commented Jan 24, 2013

At our hangout on Tuesday, we talked about using GitHub milestones more effectively, and I think this is a great case for that. I've created the following milestone to track this instead of continuing to load up this ticket with everything:

https://github.com/zetaweb/www.gittip.com/issues?milestone=26&state=open

chadwhitacre added a commit that referenced this issue Feb 1, 2013

Merge pull request #589 from nicksergeant/master
Gittip homepage redesign (for #66).

chadwhitacre added a commit that referenced this issue Feb 5, 2013

Clean up #18
Here's what I did:

 - Took out redundant getters and modified tests to expect ints
 - Standardized on 'expiration' instead of 'expiry'
 - Reverted to former FORM width, tweaking only expiration field
 - Stuck with pixels for FORM layout (a switch to em should be done as a
   whole, and #66 surely affects this)
 - Show expiration error before CVV to match order in UI
@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Feb 7, 2013

Contributor

Fuck. Yeah.

Contributor

chadwhitacre commented Feb 7, 2013

Fuck. Yeah.

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz Feb 7, 2013

Contributor

woah!

Contributor

kennethreitz commented Feb 7, 2013

woah!

@chadwhitacre

This comment has been minimized.

Show comment
Hide comment
@chadwhitacre

chadwhitacre Feb 7, 2013

Contributor

:-)

Contributor

chadwhitacre commented Feb 7, 2013

:-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.