Scott Feeney graue

Organizations

@recursecenter
graue commented on pull request facebook/react#3912
@graue

Thanks, looks great! Just two minor issues.

graue commented on pull request facebook/react#3912
@graue

nit: add a trailing comma here

graue commented on pull request facebook/react#3912
@graue

nit: maybe call it 'can pass context when shallowly rendering'?

graue commented on issue facebook/react#2393
@graue

Hi David, the scry and find functions are meant to be used with the output of renderIntoDocument, not shallow rendering. React doesn't currently pr…

graue commented on issue rust-lang/rust#25244
@graue

There are several places where the reference doc mentions "unit" or "the unit type" with an associated link to the "Primitive types" section. Examp…

graue pushed to master at graue/react
@graue
@graue
Macro documentation links to an empty page
graue commented on issue hanwen/go-mtpfs#55
@graue

Thanks, @hanwen! Sorry I never answered your question above... missed it somehow (I hadn't tried disabling Android extensions). Am super glad to he…

graue commented on issue facebook/react#3776
@graue

Something has to replace the MC though. Whether it's Flux, Relay or another system entirely. The default option of callbacks passed down 4+ levels …

graue opened issue graue/potsfyi#47
@graue
Persona login is broken; upgrade Flask-BrowserID
graue commented on issue facebook/react#3760
@graue

@gaearon: When I said this was already supposed to be supported, I was thinking of the behavior in this test: https://github.com/facebook/react/blo…

graue commented on issue facebook/react#2393
@graue

@gaearon, that's supposed to work. Are you able to get a minimal repro?

graue commented on pull request facebook/react#3716
@graue

@anyong: Sounds like a different problem. If you can create a new issue (ideally with a minimal example that shows the bug, like #3696), we'd appre…

graue starred nmn/flexy
graue closed issue facebook/react#3715
@graue
how do I disable ReactPerf?
graue commented on issue facebook/react#3715
@graue

If you're intent on using React in development mode, my recommendation would be to fork the version of React you're using, modify the measure and m…

graue pushed to master at facebook/react
@graue
graue merged pull request facebook/react#3716
@graue
Shallow render components that define contextTypes
1 commit with 25 additions and 5 deletions
graue closed issue facebook/react#3696
@graue
Shallow renderer fails when component has `contextTypes`
graue commented on pull request facebook/react#3716
@graue

You're welcome :) Yeah, actually passing context is broken right now — filed #3721 for that. But this will fix the case where the component under t…

graue opened issue facebook/react#3721
@graue
Shallow rendering should support context
graue commented on issue facebook/react#3715
@graue

You probably want to make sure the environment variable NODE_ENV is set to "production". This disables a lot of debugging that can slow down React,…

graue opened pull request facebook/react#3716
@graue
Shallow render components that define contextTypes
1 commit with 25 additions and 5 deletions
graue pushed to master at graue/react
@graue
graue commented on issue facebook/react#3696
@graue

@matthewgertner, thanks for the report. Context isn't meant to be supported with shallow rendering (i.e., we haven't tested it), but it looks like …