This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
[5.5.x] Add etcd dump and cluster status to debug reports #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0mant
approved these changes
Feb 6, 2020
knisbet
approved these changes
Feb 7, 2020
lib/report/k8s.go
Outdated
| continue | ||
| } | ||
| for _, container := range containers { | ||
| name := fmt.Sprintf("k8s-logs-%v-%v-%v", namespace, pod, container) | ||
| commands = append(commands, Cmd(name, utils.PlanetCommand(kubectl.Command("logs", pod, | ||
| "--namespace", namespace, | ||
| fmt.Sprintf("-c=%v", container)))...), | ||
| ) | ||
| fmt.Sprintf("-c=%v", container)))...)) |
There was a problem hiding this comment.
Doesn't cluster-info dump also collect container logs?
There was a problem hiding this comment.
Yes it does and hence I went forward and deleted all ad-hoc captures for kubernetes resources leaving only the kubectl cluster-info dump and the captures of previous containers since kubectl is not capturing them.
Add cluster status dump. Updates #1079.
remote calls) to be able to properly handle error conditions in the debug reporter. One of the issues previously was that the reports would contain bogus logs (i.e. previous container logs that could not be captured while they did not exist, etc.) Also replaces the ad-hoc kubernetes capture code in favor of the 'kubectl cluster-info dump' to capture all of the information as a directory tree.
a-palchikov
force-pushed
the
dmitri/5.5.x/1079-report
branch
from
d16190c
to
8da21c9
Compare
r0mant
approved these changes
Feb 8, 2020
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #1079
Requires gravitational/planet#553.