This repository has been archived by the owner on Jul 1, 2023. It is now read-only.
coredns #84
Merged
coredns #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-palchikov
approved these changes
Oct 3, 2018
r0mant
reviewed
Oct 3, 2018
monitoring/defaults_linux.go
Outdated
| func NewDNSChecker() health.Checker { | ||
| return &DNSChecker{ | ||
| QuestionA: []string{ | ||
| "leader.telekube.local", |
There was a problem hiding this comment.
I think this should be a parameter to the NewDNSChecker function, satellite should not know anything about our internal DNS names (planet knows it and can pass it here).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Do not merge until 5.2 maintenance branch created
Add a check to test DNS resolution for CoreDNS by querying the cluster leader. Unfortunately, it's not currently possible to also query the k8s service discovery, due to a dependency cycle on the checks passing in order to complete provisioning coredns rbac permissions, so just test leader election.
Updates https://github.com/gravitational/gravity.e/issues/3742