Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid error in MUX by always responding with healthz response to HTTP get requests #2740

Closed
klizhentas opened this issue May 27, 2019 · 1 comment

Comments

@klizhentas
Copy link
Contributor

commented May 27, 2019

Description

Whenever anyone does HTTP get request when MUX is turned on on, you get:

May 27 21:59:30 proxy1 /usr/local/bin/teleport[6342]: WARN [MX:PROXY:] "\nERROR REPORT:\nOriginal Error: *trace.BadParameterError failed to detect protocol by prefix: [71 69 84]\nStack Trace:\n\t/home/sasha/go/src/github.com/gravitational/teleport/lib/multiplexer/multiplexer.go:318 github.com/gravitational/teleport/lib/multiplexer.detectProto\n\t/home/sasha/go/src/github.com/gravitational/teleport/lib/multiplexer/multiplexer.go:260 github.com/gravitational/teleport/lib/multiplexer.detect\n\t/home/sasha/go/src/github.com/gravitational/teleport/lib/multiplexer/multiplexer.go:197 github.com/gravitational/teleport/lib/multiplexer.(*Mux).detectAndForward\n\t/usr/local/go/src/runtime/asm_amd64.s:2362 runtime.goexit\nUser Message: failed to detect protocol by prefix: [71 69 84]\n" multiplexer/multiplexer.go:200

Solution

It should be easy to respond to GET requests with healthz response, what will make it much easier for default healtchecks done by load balancers to work out of the box.

@webvictim

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

The scope of this is changing a bit - we'll tidy up the log spam and handle the connections more gracefully but we won't be implementing an HTTP response by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.