Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate the joined-tokens code to the OSS release. #10288

Merged
merged 8 commits into from Feb 15, 2022
Merged

Migrate the joined-tokens code to the OSS release. #10288

merged 8 commits into from Feb 15, 2022

Conversation

hatched
Copy link
Contributor

@hatched hatched commented Feb 10, 2022 •
edited

OSS backend changes for gravitational/webapps#592

@hatched hatched marked this pull request as ready for review February 10, 2022 22:31
zmb3
zmb3 approved these changes Feb 14, 2022
View reviewed changes
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: require.Nil(t, err) is slightly better expressed as require.NoError(t, err).

@hatched hatched enabled auto-merge (squash) February 15, 2022 16:28
@hatched hatched merged commit 3cd8109 into master Feb 15, 2022
@hatched hatched deleted the hatched/move-joined-tokens branch February 15, 2022 17:14
hatched added a commit that referenced this pull request Mar 14, 2022
@hatched
Migrate the joined-tokens code to the OSS release. (#10288)
c3c4854 
* Migrate the joined-tokens code to the OSS release.

* migrate install node scripts from enterprise to oss.

* Add missing licenses

* add missing license.

* update require.nil to require.noError.
@hatched hatched mentioned this pull request Mar 14, 2022
Merged
zmb3 pushed a commit that referenced this pull request Mar 15, 2022
@hatched
Migrate the joined-tokens code to the OSS release. (#10288) (#11116)
79fe94e 
* Migrate the joined-tokens code to the OSS release.

* migrate install node scripts from enterprise to oss.

* Add missing licenses

* add missing license.

* update require.nil to require.noError.
@alexatcanva alexatcanva mentioned this pull request Oct 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmb3 zmb3 zmb3 approved these changes

@atburke atburke atburke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hatched @zmb3 @atburke