Switch to warning in case of resource origin clash. #10947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tener
added
application-access
database-access
codingllama
approved these changes
Mar 8, 2022
greedy52
approved these changes
Mar 8, 2022
Right now it is "whatever was there first, wins". With respect to |
zmb3
approved these changes
Mar 8, 2022
Tener
added a commit
that referenced
this pull request
Mar 10, 2022
Tener
added a commit
that referenced
this pull request
Mar 10, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to have a resource from different origins:
static(apps, dbs)dynamic(apps, dbs)cloud(dbs)(Note: currently desktops can only be
dynamicAFAICT, sourced from LDAP)Currently in this situation we ignore the clash and only issue a debug-level log message. This PR changes that to warning to make it easier to diagnose scenarios such as:
dynamicapp fails to show up on asstaticapp takes precedencedynamic/clouddb fails to show up on asstaticdb takes precedencedynamicdb and oneclouddb show up randomly depending on which wins the data race to be the first in the node cache.Fixes #10797.