[v7] Proxy restart fixes #12546
Merged
[v7] Proxy restart fixes #12546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0mant
approved these changes
May 11, 2022
Tener
approved these changes
May 12, 2022
* Remove unused backend wrapper from Cache * Remove double printShutdownStatus * Fix readyz race condition * Test coverage for the readyz.monitor fix * Close listeners immediately in proxy.shutdown * Use and handle net.ErrClosed correctly This adapts utils.IsUseOfClosedNetworkError to check for net.ErrClosed even inside trace.Aggregate errors, makes it so that we always return something that would pass errors.Is(err, net.ErrClosed) when returning from a (net.Listener).Accept(), and handles closed listeners within our various Serve() loops so that we don't hit spurious backoff waits while shutting down. * Close listeners early and emitters late * Test coverage for the proxy listener changes * Revert some errors back to trace.ConnectionProblem * Reduce PR scope to just the proxy, add comments * Improve error logging.
espadolini
force-pushed
the
espadolini/v7-proxy-restart
branch
from
2ec877b
to
fdc848c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #11802 to branch/v7