Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance using session trackers in large clusters #12584

Merged
merged 11 commits into from
May 23, 2022
Merged

Improve performance using session trackers in large clusters #12584

merged 11 commits into from
May 23, 2022

Conversation

xacrimon
Copy link
Contributor

@xacrimon xacrimon commented May 11, 2022 •
edited

Measures taken:

  • Only request single trackers from clients where possible
  • Don't refetch roles uselessly in a loop.

These measures reduce the amount of tracker loads we make as well as significantly reduce filtering cost, combined with the below PR from @Joerger which also eliminates needless tracker fetching on a ticker from nodes, performance should be drastically improved for large clusters with many sessions and nodes. Due to needed filter restructuring, this also implements the same fix as #12569.

Related patches:

@xacrimon xacrimon self-assigned this May 11, 2022
@xacrimon xacrimon mentioned this pull request May 11, 2022
Closed
@xacrimon xacrimon requested review from zmb3 and Joerger May 11, 2022 20:22
@xacrimon xacrimon marked this pull request as ready for review May 11, 2022 20:23
@github-actions github-actions bot added the tsh tsh - Teleport's command line tool for logging into nodes running Teleport. label May 11, 2022
rosstimothy
rosstimothy reviewed May 11, 2022
View reviewed changes
tool/tsh/kube.go Outdated Show resolved Hide resolved
zmb3
zmb3 reviewed May 11, 2022
View reviewed changes
lib/auth/auth_with_roles.go Outdated Show resolved Hide resolved
lib/auth/auth_with_roles.go Show resolved Hide resolved
lib/auth/auth_with_roles.go Outdated Show resolved Hide resolved
@xacrimon xacrimon requested review from rosstimothy and zmb3 May 12, 2022 05:00
Joerger
Joerger reviewed May 13, 2022
View reviewed changes
lib/auth/auth_with_roles.go Outdated Show resolved Hide resolved
lib/auth/auth_with_roles.go Show resolved Hide resolved
lib/auth/auth_with_roles.go Show resolved Hide resolved
lib/auth/auth_with_roles.go Outdated Show resolved Hide resolved
@xacrimon xacrimon requested a review from Joerger May 17, 2022 10:37
Joerger
Joerger approved these changes May 19, 2022
View reviewed changes
lib/auth/auth_with_roles.go Outdated Show resolved Hide resolved
xacrimon and others added 2 commits May 20, 2022 09:48
@xacrimon xacrimon enabled auto-merge (squash) May 20, 2022 07:50
@xacrimon xacrimon merged commit 756c5e5 into master May 23, 2022
@github-actions
Copy link

@xacrimon See the table below for backport results.

Branch Result
branch/v9 Failed

xacrimon added a commit that referenced this pull request May 23, 2022
@xacrimon
Improve performance using session trackers in large clusters (#12584)
421cb45
@xacrimon xacrimon mentioned this pull request May 23, 2022
Merged
xacrimon added a commit that referenced this pull request May 24, 2022
@xacrimon
Improve performance using session trackers in large clusters (#12584) (…
cc65ae1 
…#12832)
@webvictim webvictim mentioned this pull request Jun 8, 2022
Closed
@zmb3 zmb3 deleted the joel/sess-track-perf branch April 26, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joerger Joerger Joerger approved these changes

@rosstimothy rosstimothy rosstimothy approved these changes

@strideynet strideynet Awaiting requested review from strideynet

@zmb3 zmb3 Awaiting requested review from zmb3

Assignees

@xacrimon xacrimon

Labels
backport-required tsh tsh - Teleport's command line tool for logging into nodes running Teleport.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xacrimon @zmb3 @Joerger @rosstimothy