-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance using session trackers in large clusters #12584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
reviewed
May 11, 2022
zmb3
reviewed
May 11, 2022
db5390a
to
72cbc06
Compare
rosstimothy
approved these changes
May 13, 2022
Joerger
reviewed
May 13, 2022
Co-authored-by: Brian Joerger <bjoerger@goteleport.com>
240a3bf
to
670eb86
Compare
Joerger
approved these changes
May 19, 2022
Co-authored-by: Brian Joerger <bjoerger@goteleport.com>
xacrimon
added a commit
that referenced
this pull request
May 23, 2022
Merged
xacrimon
added a commit
that referenced
this pull request
May 24, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Measures taken:
These measures reduce the amount of tracker loads we make as well as significantly reduce filtering cost, combined with the below PR from @Joerger which also eliminates needless tracker fetching on a ticker from nodes, performance should be drastically improved for large clusters with many sessions and nodes. Due to needed filter restructuring, this also implements the same fix as #12569.
Related patches: