Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include system annotations that are present in the requested roles in an access request #41821

Merged
merged 5 commits into from
May 21, 2024

Conversation

lxea
Copy link
Contributor

@lxea lxea commented May 21, 2024

From https://github.com/gravitational/teleport-private/pull/1434 and https://github.com/gravitational/teleport-private/pull/1550

changelog: Only include system annotations that are present in the requested roles in an access request

lxea added 4 commits May 21, 2024 17:32
check a user can do a review in SetAccessRequestState

add test for where clause, ensure correct annotations are permitted

test if review conditions are set and deny if access_request can be updated

Where conditions are working as intended, update docs to avoid confusion
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@lxea lxea added the no-changelog Indicates that a PR does not require a changelog entry label May 21, 2024
Copy link

🤖 Vercel preview here: https://docs-gm1idrqh5-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-c5qckty93-goteleport.vercel.app/docs/ver/preview

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from ptgott May 21, 2024 17:10
@lxea lxea enabled auto-merge May 21, 2024 17:15
@lxea lxea added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 21, 2024
@zmb3 zmb3 added this pull request to the merge queue May 21, 2024
Merged via the queue into master with commit 9637086 May 21, 2024
41 of 42 checks passed
@zmb3 zmb3 deleted the lxea/greedy-atter-search-as-roles-fix branch May 21, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation size/md tctl tctl - Teleport admin tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants