Add gRPC conversion support for BillingCard events #7303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallinsky
approved these changes
Jun 15, 2021
russjones
approved these changes
Jun 15, 2021
There was a problem hiding this comment.
@xacrimon @fspmarshall PR looks good to me. Any ideas on how we can prevent these issues from occurring in the future? Seems we have hit these kinds of issues a few times now.
|
The way to do it I think would be writing some list of things that need changing when you edit some code such as adding an event. There isn’t really a good way to prevent it fully in a language like Go. Tests also weren’t added by whomever implemented this event as they should. If a test was written for billing cards this would not have happened. I think the core takeaway is more testing and enforcing it as code reviewers. |
xacrimon
added a commit
that referenced
this pull request
Jun 15, 2021
xacrimon
added a commit
that referenced
this pull request
Jun 15, 2021
xacrimon
added a commit
that referenced
this pull request
Jun 16, 2021
xacrimon
added a commit
that referenced
this pull request
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for BillingCard events to functions used for converting from gRPC formats and back.
Fixes #7274