From 62a92b944060d71e7019bade99d66be5a4ba831c Mon Sep 17 00:00:00 2001
From: Titouan Compiegne <titouan.compiegne@gmail.com>
Date: Sat, 12 Nov 2016 10:54:09 +0100
Subject: [PATCH] feat(analytics) : handle deleted api/application analytics

This closes gravitee-io/issues#312
---
 src/app/api/admin/analytics/analytics.controller.js  |  3 ++-
 .../admin/analytics/analyticsApplicationModel.html   |  9 ++++-----
 .../details/analytics/analytics.controller.js        |  3 ++-
 .../details/analytics/analyticsAPIModel.html         |  7 ++++---
 src/app/platform/dashboard/dashboardModel.html       | 12 ++++++++++--
 5 files changed, 22 insertions(+), 12 deletions(-)

diff --git a/src/app/api/admin/analytics/analytics.controller.js b/src/app/api/admin/analytics/analytics.controller.js
index 1245c7e5e2..cf82912904 100644
--- a/src/app/api/admin/analytics/analytics.controller.js
+++ b/src/app/api/admin/analytics/analytics.controller.js
@@ -178,9 +178,10 @@ class ApiAnalyticsController {
     } else {
       this.ApplicationService.get(id).then(response => {
         _this.cache[id] = response.data;
+        _this.cache[id].exists = true;
         deferred.resolve(this.cache[id]);
       }).catch(function() {
-        _this.cache[id] = { 'name' : id };
+        _this.cache[id] = { 'name' : id, 'exists' : false };
         deferred.resolve(_this.cache[id]);
       });
     }
diff --git a/src/app/api/admin/analytics/analyticsApplicationModel.html b/src/app/api/admin/analytics/analyticsApplicationModel.html
index b58cf27345..bd2caebdc9 100644
--- a/src/app/api/admin/analytics/analyticsApplicationModel.html
+++ b/src/app/api/admin/analytics/analyticsApplicationModel.html
@@ -15,9 +15,8 @@
     limitations under the License.
 
 -->
-<span ng-if="entity.name">
-  {{entity.name}}
-</span>
-<span ng-if="!entity.name">
-  {{id}}
+<span ng-if="entity.exists">{{entity.name}}</span>
+
+<span ng-if="!entity.exists" style="color: grey;">
+  Deleted application
 </span>
diff --git a/src/app/application/details/analytics/analytics.controller.js b/src/app/application/details/analytics/analytics.controller.js
index 46578ff827..a6f33ed6c4 100644
--- a/src/app/application/details/analytics/analytics.controller.js
+++ b/src/app/application/details/analytics/analytics.controller.js
@@ -175,9 +175,10 @@ class ApplicationAnalyticsController {
     } else {
       this.ApiService.get(id).then(response => {
         _this.cache[id] = response.data;
+        _this.cache[id].exists = true;
         deferred.resolve(this.cache[id]);
       }).catch(function() {
-        _this.cache[id] = { 'name' : id, 'version' : 'N/A' };
+        _this.cache[id] = { 'name' : id, 'exists' : false };
         deferred.resolve(_this.cache[id]);
       });
     }
diff --git a/src/app/application/details/analytics/analyticsAPIModel.html b/src/app/application/details/analytics/analyticsAPIModel.html
index e32b9ef1a7..ba4cd8d0eb 100644
--- a/src/app/application/details/analytics/analyticsAPIModel.html
+++ b/src/app/application/details/analytics/analyticsAPIModel.html
@@ -15,9 +15,10 @@
     limitations under the License.
 
 -->
-<span ng-if="entity.name">
+<span ng-if="entity.exists">
   {{entity.name}} <small>({{entity.version}})</small>
 </span>
-<span ng-if="!entity.name">
-  {{id}}
+
+<span ng-if="!entity.exists" style="color: grey;">
+  Deleted API
 </span>
diff --git a/src/app/platform/dashboard/dashboardModel.html b/src/app/platform/dashboard/dashboardModel.html
index 05a1d11d78..e5121fb239 100644
--- a/src/app/platform/dashboard/dashboardModel.html
+++ b/src/app/platform/dashboard/dashboardModel.html
@@ -19,6 +19,14 @@
   <a ng-if="entity.exists" ui-sref="apis.admin.analytics({ apiId: entity.id } )">
     {{entity.name}} <small ng-if="model === 'api'">({{entity.version}})</small>
   </a>
-  <span ng-if="!entity.exists" style="color: grey;">{{entity.name}}</span>
+  <span ng-if="!entity.exists" style="color: grey;">
+    Deleted API
+  </span>
+</span>
+
+<span ng-if="entity && model === 'application'">
+  <span ng-if="entity.exists">{{entity.name}}</span>
+  <span ng-if="!entity.exists" style="color: grey;" layout="row">
+    Deleted application
+  </span>
 </span>
-<span ng-if="entity && model === 'application'" ng-style="!entity.exists && {'color':'grey'}">{{entity.name}}</span>