Skip to content
This repository has been archived by the owner on Oct 20, 2021. It is now read-only.

Commit

Permalink
Browse files Browse the repository at this point in the history
fix(logging): add a max duration at the platform level
  • Loading branch information
NicolasGeraud committed Feb 14, 2019
1 parent 1b600ed commit e327ad4
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 5 deletions.
Expand Up @@ -24,19 +24,22 @@ class ApiLoggingConfigurationController {
private initialApi: any;
private api: any;
private formLogging: any;
private maxDuration: any;

constructor(
private ApiService: ApiService,
private NotificationService: NotificationService,
private $mdDialog: angular.material.IDialogService,
private $stateParams,
private $rootScope,
private $scope
private $scope,
private Constants
) {
'ngInject';

this.initialApi = _.cloneDeep(this.$scope.$parent.apiCtrl.api);
this.api = _.cloneDeep(this.$scope.$parent.apiCtrl.api);
this.maxDuration = Constants.logging.maxDurationMillis;

this.$scope.loggingModes = [
{
Expand Down
11 changes: 7 additions & 4 deletions src/management/api/analytics/logs/logging-configuration.html
Expand Up @@ -25,10 +25,13 @@ <h1>Logging</h1>
<div class="gv-form">
<h2>Configuration</h2>
<div class="gv-form-content">
<div class="hints" style="color: #EF3B3A">Use logging with caution and only for development purpose since it can have impact on API performances and is requiring more spaces for analytics storage.</div>

<br />

<p>
Use logging with caution and only for development purpose. It can have an impact on API performances and is requiring more spaces for analytics storage.
<div class="gv-page-draft-banner" ng-if="loggingCtrl.maxDuration && loggingCtrl.maxDuration > 0">
<ng-md-icon icon="warning" style="fill: #ce4844"></ng-md-icon>
A maximum duration of <code>{{loggingCtrl.maxDuration}}</code>milliseconds will be added to your condition if not present.
</div>
</p>
<div layout="column" layout-wrap layout-gt-sm="row">
<div flex-xs flex="50">
<div layout-xs="column" flex-xs="50">
Expand Down
10 changes: 10 additions & 0 deletions src/management/configuration/portal/portal.html
Expand Up @@ -293,6 +293,16 @@ <h2>API Quality</h2>
</div>
</div>

<div class="gv-form">
<h2>API Quality</h2>
<div class="gv-form-content" layout="column">
<md-input-container class="md-block" flex-gt-xs>
<label>Maximum duration in millisecond when a logging mode is activated (0 means not used)</label>
<input type="number" min="0" ng-model="$ctrl.Constants.logging.maxDurationMillis">
</md-input-container>
</div>
</div>

<md-card-actions>
<md-button class="md-raised md-primary" ng-click="$ctrl.save()" permission permission-only="['portal-settings-c', 'portal-settings-u', 'portal-settings-d']">Save</md-button>
<md-button class="md-raised" ng-click="$ctrl.reset()" permission permission-only="['portal-settings-c', 'portal-settings-u', 'portal-settings-d']">Reset</md-button>
Expand Down

0 comments on commit e327ad4

Please sign in to comment.