Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[portal] [google] GoogleAuthenticationResource userinfo endpoint url needs configuration and userInfo id issue #1323
Once user obtained google oauth2 webapp client clientId and clientSecret and setup in gravitee.yml for security:
Steps to Reproduce (for bugs)
With the mentioned issue fixed, Sign in with Google on the portal is working
This is 1.17 code
If you change private static final String GOOGLE_USER_INFO_URL = "https://www.googleapis.com/oauth2/v3/userinfo"; that should fix the issue i saw. it will still be good practice to null check sub field.
Allowing override will bring flexibility if google changes things. But I can live with it if it is into backlog.
We care more about the #1324 which is standard OAuth2. If you guys can try and confirm whether you run into the same issue. That will be great. I do have patch for 1324 that is the preferred config solution I suggested. If need to contribute, i will need to go through a company approval process. Or if you have a better solution for 1324, that will be great.