New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[management-api] Page ids don't have to contain the page title #148

Closed
NicolasGeraud opened this Issue Jul 16, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@NicolasGeraud
Member

NicolasGeraud commented Jul 16, 2016

Page id is compound of the api id + page title.

But the title could be changed (and not the page id).
It's better to use an UID for the page id.

@NicolasGeraud NicolasGeraud added this to the 0.17.0 milestone Jul 16, 2016

NicolasGeraud added a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Jul 16, 2016

@NicolasGeraud NicolasGeraud self-assigned this Jul 16, 2016

@brasseld

This comment has been minimized.

Member

brasseld commented Jul 16, 2016

And it is exactly the same for API where its name can be changed....

@NicolasGeraud

This comment has been minimized.

Member

NicolasGeraud commented Jul 17, 2016

and Application to ?
I'll remove the IdGenerator.

Ok with that?

@brasseld

This comment has been minimized.

Member

brasseld commented Jul 17, 2016

👍

NicolasGeraud added a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Jul 17, 2016

NicolasGeraud added a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Jul 17, 2016

@NicolasGeraud

This comment has been minimized.

Member

NicolasGeraud commented Jul 17, 2016

done, you can review it

brasseld added a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Jul 17, 2016

@aelamrani aelamrani changed the title from [rest] Page ids don't have to contain the page title to [management-api] Page ids don't have to contain the page title Jul 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment