New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[management-ui] CORS cant save customer Access-Control-Allow-Headers,for excample X-Gravitee-Api-Key. #1524

Closed
catchUheart opened this Issue Sep 28, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@catchUheart

catchUheart commented Sep 28, 2018

Expected Behavior

how can i save the X-Gravitee-Api-Key in Access-Control-Allow-Headers.

Your Environment

  • Version used:1.19.3
  • Browser Name and version:
  • Operating System and version:win10

@brasseld brasseld self-assigned this Sep 28, 2018

@brasseld brasseld added the type: bug label Sep 28, 2018

@brasseld brasseld removed their assignment Sep 28, 2018

@brasseld

This comment has been minimized.

Member

brasseld commented Sep 28, 2018

Hi @catchUheart

I just had a try and was able to reproduce.

I think this is because you did not enable CORS at the top of page.
One CORS is enabled, you can define and save all the form's fields.

I keep this issue to disabled fields when CORS is disabled.

@brasseld brasseld changed the title from CORS cant save customer Access-Control-Allow-Headers,for excample X-Gravitee-Api-Key. to [management-ui] CORS cant save customer Access-Control-Allow-Headers,for excample X-Gravitee-Api-Key. Sep 28, 2018

@catchUheart

This comment has been minimized.

catchUheart commented Sep 28, 2018

The CORS is in active.
In Access-Control-Allow-Headers,it seems that can only save the headers which is in the drop down list,
like Content-type,Cache-control and so on.But,cant save the X-Gravitee-Api-Key which is not in the drop down list.

@brasseld

This comment has been minimized.

Member

brasseld commented Sep 28, 2018

Ok, I think this is dure to the material design.

When you type X-Gravitee-Api-Key, you must have to press enter key to take care of the new header.

Please let us know.

Regards,

@catchUheart

This comment has been minimized.

catchUheart commented Sep 28, 2018

OK,it comes to work.
Thank you!

@brasseld brasseld added this to the 1.20.0 milestone Sep 28, 2018

@brasseld

This comment has been minimized.

Member

brasseld commented Sep 28, 2018

Thanks for your feedback @catchUheart

So, IMHO, user should not be able to define CORS if this latest is inactive.

brasseld added a commit to gravitee-io/gravitee-management-webui that referenced this issue Oct 2, 2018

NicolasGeraud added a commit to gravitee-io/gravitee-management-webui that referenced this issue Oct 4, 2018

NicolasGeraud added a commit to gravitee-io/gravitee-management-webui that referenced this issue Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment