New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gateway] Expression Language : path params from policies #253

Closed
brasseld opened this Issue Oct 14, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@brasseld
Member

brasseld commented Oct 14, 2016

Today the values of path params (like /api/products/:product_id) are injected in the execution context in the form of indexed values. They are accessed through :
#request.path[0],#request.path[1], etc.

The problem is that the index is based on the root context-path of the API meaning that if API's context-path is /products/v1 and the policy is set for path /:product_id/prices, the final path is /products/v1/:product_id/prices.

But from the policy side, the index should not be based on a path including context-path. It is probably error-prone.

Or perhaps, we have to provide a new property on the request to select only "resolved" path.

brasseld added a commit to gravitee-io/gravitee-gateway that referenced this issue Oct 19, 2016

@brasseld brasseld added this to the 1.0.0 milestone Oct 19, 2016

@brasseld brasseld self-assigned this Oct 19, 2016

brasseld added a commit to gravitee-io/gravitee-gateway-api that referenced this issue Oct 20, 2016

brasseld added a commit to gravitee-io/gravitee-gateway that referenced this issue Oct 20, 2016

NicolasGeraud added a commit to gravitee-io/gravitee-gateway-api that referenced this issue Oct 20, 2016

NicolasGeraud added a commit to gravitee-io/gravitee-gateway that referenced this issue Oct 20, 2016

NicolasGeraud added a commit to gravitee-io/gravitee-gateway that referenced this issue Oct 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment