Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[policy] [dynamic-routing] Invalid path with virtual host feature #2640

Closed
tnus opened this issue Sep 20, 2019 · 2 comments

Comments

@tnus
Copy link

commented Sep 20, 2019

Not sure if the dynamic routing policy is working correctly. The match expression does not work with a "/" character as prefix. Without the slash as prefix the expression works.

Yesterday i submitted the bug 2632. I saw that it was closed and tried the fix on my local system.
dynamic-routing-api-1-0.zip

Expected Behavior

When i define a subpath in the api designer policy, e.g. "/v1", then the match expression should also start with a slash, e.g. "/v1(.*)", like it is described in the documentation.

Current Behavior

The DynamicRoutingPolicy does not find a rule which is matching the expression. When i change the match expression to "v1(.*)" then it works

Possible Solution

Steps to Reproduce (for bugs)

  1. In the API Designer create a subpath, e.g. "/v1"
  2. Add the dynamic routing policy to this path
  3. Set the match expression to "/v1(.*)"

An example of the api is attached bellow.

Context

If have multiple paths of an api. The dynamic routing is different for each path.

Your Environment

  • Version used: 1.29.1-SNAPSHOT
  • Browser Name and version: Google Chrome
  • Operating System and version: Windows 10
@tnus

This comment has been minimized.

Copy link
Author

commented Sep 20, 2019

brasseld added a commit to gravitee-io/gravitee-policy-dynamic-routing that referenced this issue Sep 20, 2019
@brasseld brasseld self-assigned this Sep 20, 2019
@brasseld brasseld added this to the APIM - 1.29.1 milestone Sep 20, 2019
@brasseld brasseld changed the title API Gateway - Dynamic Routing Policy [policy] [dynamic-routing] Invalid path with virtual host feature Sep 20, 2019
@tnus

This comment has been minimized.

Copy link
Author

commented Sep 24, 2019

Thx, for fixing this bug so fast. Do you know when it will be merged and the version 1.29.1 will be released?

NicolasGeraud added a commit to gravitee-io/gravitee-policy-dynamic-routing that referenced this issue Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
API Management
Awaiting triage
3 participants
You can’t perform that action at this time.