Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gravitee-policy-request-validation] Support order of rules #2666

Closed
brightlizard opened this issue Sep 23, 2019 · 3 comments

Comments

@brightlizard
Copy link

@brightlizard brightlizard commented Sep 23, 2019

We are trying to group several rules(conditions) inside one “Validate Request Policy” to reduce quantity of policies in UI view and expecting that the order of rules will be the same as defined in UI/API_definition.
For example:

  1. Constraint / Type = NOT_NULL
  2. Constraint / Type = PATTERN
    .. and so on
    But unfortunately the order is not guaranteed because of this line of code -> “Set violations = new HashSet<>();”
    It would be great to change HashSet structure to LinkedHashSet or ArrayList.
    We can make PR if you want.
@brasseld

This comment has been minimized.

Copy link
Member

@brasseld brasseld commented Sep 23, 2019

PR would be really welcomed :)

brightlizard pushed a commit to brightlizard/gravitee-policy-request-validation that referenced this issue Sep 24, 2019
brightlizard pushed a commit to brightlizard/gravitee-policy-request-validation that referenced this issue Oct 4, 2019
@brightlizard

This comment has been minimized.

Copy link
Author

@brightlizard brightlizard commented Oct 9, 2019

Please check the PR, all checks seems to be passed and conflicts resolved.

@brasseld

This comment has been minimized.

Copy link
Member

@brasseld brasseld commented Oct 9, 2019

Hi @brightlizard

We will. I've associated the issue to 1.29.x to make it available within the next minor release

brightlizard added a commit to brightlizard/gravitee-policy-request-validation that referenced this issue Oct 18, 2019
brasseld added a commit to gravitee-io/gravitee-policy-request-validation that referenced this issue Oct 29, 2019
NicolasGeraud added a commit to gravitee-io/gravitee-policy-request-validation that referenced this issue Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
API Management
Awaiting triage
3 participants
You can’t perform that action at this time.