New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[management-api] [fetcher] GitLab - access to non public project #326

Closed
vdelattre opened this Issue Nov 22, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@vdelattre

vdelattre commented Nov 22, 2016

In documentation, i want to make a link to gitlab, but my project needs an authentification

@brasseld brasseld changed the title from GitLab - access to non public project to [management-api] [fetcher] GitLab - access to non public project Nov 22, 2016

@brasseld

This comment has been minimized.

Member

brasseld commented Nov 22, 2016

Some words about your need:

You want to create a new documentation page which is based on a GitLab repository (project) but this one needs an authentication (internal / private project).

Two options here:

  • Use a technical account to clone the Git repository and use provided credentials
  • Use a technical account to invoke the GitLab API to retrieve a single document (by using a path reference).
@NicolasGeraud

This comment has been minimized.

Member

NicolasGeraud commented Nov 22, 2016

I think we have to provide a gitlab fetcher. But where may we provide credentials ?

  • In the fetcher configuration
    PROS : fine grained authorization
    CONS: we store sensitive datas, user must configure credentials on each page
  • in the gravitee.yml
    PROS: used in all page, user don't have to give his credentials
    CONS: need a technical account on gitlab

I prefer the second solution, it will be mush easier to publish documentation pages

@vdelattre

This comment has been minimized.

vdelattre commented Nov 22, 2016

I add my comment:
If credential is store in gravitee.yml, it means that this technical account have access to all projects in gitlab.
If credential is in the fetcher, it can be different by project or groups in gitlab

@brasseld

This comment has been minimized.

Member

brasseld commented Nov 22, 2016

I'm agree with the second solution.

An other one would be to define and use the concept of environnement and a hierarchy of "configuration" / "system properties" around them.

Global configuration
 | - Properties
 | - Qualif env.
    | - Resources
    | - Properties
 | - Prod env.
    | - Resources
    | - Properties

In this case, credentials can be part of Global configuration > Properties

@brasseld brasseld added this to the 1.2.0 milestone Nov 29, 2016

@NicolasGeraud NicolasGeraud self-assigned this Nov 30, 2016

@NicolasGeraud

This comment has been minimized.

Member

NicolasGeraud commented Dec 1, 2016

@vdelattre wdyt
capture d ecran 2016-12-01 22 58 11

NicolasGeraud added a commit to gravitee-io/gravitee-fetcher-gitlab that referenced this issue Dec 1, 2016

NicolasGeraud added a commit to gravitee-io/gravitee-management-webui that referenced this issue Dec 1, 2016

NicolasGeraud added a commit to gravitee-io/gravitee-fetcher-gitlab that referenced this issue Dec 2, 2016

NicolasGeraud added a commit to gravitee-io/gravitee-fetcher-gitlab that referenced this issue Dec 2, 2016

NicolasGeraud added a commit to gravitee-io/gravitee-fetcher-gitlab that referenced this issue Dec 2, 2016

brasseld added a commit to gravitee-io/gravitee-fetcher-gitlab that referenced this issue Dec 4, 2016

brasseld added a commit to gravitee-io/gravitee-management-webui that referenced this issue Dec 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment