New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[portal] API visibility icons aren't correctly separated #368

Closed
arnaudforaison opened this Issue Dec 8, 2016 · 13 comments

Comments

Projects
None yet
4 participants
@arnaudforaison

arnaudforaison commented Dec 8, 2016

On Global Settings API, radio buttons icons for API visibility aren't correctly separated

Expected Behavior

Well separeted

Current Behavior

gravitee_outofsync-issue

Possible Solution

Steps to Reproduce (for bugs)

  1. Manage an API
  2. Go to Global Settings -> General

Context

Your Environment

  • Version used: 1.1.0
  • Browser Name and version: Chrome 55.0.2883.75
  • Operating System and version: Ubuntu

@NicolasGeraud NicolasGeraud changed the title from API visibility icons aren't correctly separated to [portal] API visibility icons aren't correctly separated Dec 8, 2016

@NicolasGeraud NicolasGeraud added this to the 1.2.0 milestone Dec 9, 2016

@NicolasGeraud NicolasGeraud changed the title from [portal] API visibility icons aren't correctly separated to [portal] API visibility icons aren't correctly separated Dec 9, 2016

@NicolasGeraud

This comment has been minimized.

Member

NicolasGeraud commented Dec 9, 2016

wdyt if api visibility radio buttons are displayed in column ?
capture d ecran 2016-12-09 14 03 09

@brasseld

This comment has been minimized.

Member

brasseld commented Dec 9, 2016

Hum.... finally we have the choice between public and private, so why not just a switch ?
https://material.angularjs.org/latest/demo/switch

@NicolasGeraud

This comment has been minimized.

Member

NicolasGeraud commented Dec 9, 2016

you're totally right.

@brasseld

This comment has been minimized.

Member

brasseld commented Dec 9, 2016

You mean, I'm totally write, right ?

@NicolasGeraud

This comment has been minimized.

Member

NicolasGeraud commented Dec 9, 2016

You're write

@NicolasGeraud

This comment has been minimized.

Member

NicolasGeraud commented Dec 9, 2016

@NicolasGeraud

This comment has been minimized.

Member

NicolasGeraud commented Dec 10, 2016

capture d ecran 2016-12-09 23 16 57

capture d ecran 2016-12-09 23 17 23

wdyt ?

@NicolasGeraud NicolasGeraud self-assigned this Dec 10, 2016

@brasseld

This comment has been minimized.

Member

brasseld commented Dec 11, 2016

Imho:

  1. Lifecycle status, in admin mode, must be part of the header because we have currently no way to get this status when we are in others screen. So why not having this status and the relative switch (or an icon) in the API header ?
  2. Visibility is a concept mainly used to manage members. So why not moving the switch into the members screen ? Or perhaps simply change the switch for a select combobox because it is easier to understand ?
@NicolasGeraud

This comment has been minimized.

Member

NicolasGeraud commented Dec 11, 2016

Agree with your first point, disagree with the second.
For a new api publisher, I think it's not obvious to go to Members section to manage visibility of the API.

@NicolasGeraud

This comment has been minimized.

Member

NicolasGeraud commented Dec 11, 2016

perhaps simply change the switch for a select combobox because it is easier to understand ?

this is a good idea, you have UX skills :)

@brasseld

This comment has been minimized.

Member

brasseld commented Dec 11, 2016

I'm still better to write java source code ;)

So do we need two different issues for those things ?

@brasseld

This comment has been minimized.

Member

brasseld commented Dec 19, 2016

@NicolasGeraud what is the status of this issue ?

@NicolasGeraud

This comment has been minimized.

Member

NicolasGeraud commented Dec 20, 2016

I haven't work on that since last message.
I'll try to make a PR tomorrow

NicolasGeraud added a commit to gravitee-io/gravitee-management-webui that referenced this issue Jan 7, 2017

NicolasGeraud added a commit to gravitee-io/gravitee-management-webui that referenced this issue Jan 7, 2017

aelamrani added a commit to gravitee-io/gravitee-management-webui that referenced this issue Jan 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment