Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[management][github idp] user without space in their username fail to authenticate #5507

Closed
NicolasGeraud opened this issue Apr 29, 2021 · 0 comments
Closed

[management][github idp] user without space in their username fail to authenticate #5507

NicolasGeraud opened this issue Apr 29, 2021 · 0 comments
Assignees
@leleueri
Labels
project: APIM status: in review type: bug
Milestone
APIM - 3.5.18

Comments

@NicolasGeraud
Copy link
Member

Expected Behavior

a github user can use a name without space

Current Behavior

exception is thrown here :
https://github.com/gravitee-io/gravitee-management-rest-api/blob/6eda4ca2a249f96f2051edd383f2f55b1cb9a2d9/gravitee-rest-api-service/src/main/java/io/gravitee/rest/api/service/impl/UserServiceImpl.java#L1552

Possible Solution

fix this assumption https://github.com/gravitee-io/gravitee-management-rest-api/blob/6eda4ca2a249f96f2051edd383f2f55b1cb9a2d9/gravitee-rest-api-model/src/main/java/io/gravitee/rest/api/model/configuration/identity/github/GitHubIdentityProviderEntity.java#L90

Your Environment

  • Version used: it has to be fixed in all supported versions
@NicolasGeraud NicolasGeraud added this to the APIM - 3.5.x milestone Apr 29, 2021
@leleueri leleueri self-assigned this Jul 21, 2021
leleueri added a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Jul 21, 2021
@leleueri
fix: github idp - test length of the array before accessing the secon…
b4317fe 
…d element

fixes gravitee-io/issues#5507
@leleueri leleueri mentioned this issue Jul 21, 2021
Merged
jhaeyaert pushed a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Jul 29, 2021
@leleueri @jhaeyaert
fix: github idp - test length of the array before accessing the secon…
32c3fe8 
…d element

fixes gravitee-io/issues#5507
jhaeyaert pushed a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Jul 29, 2021
@leleueri @jhaeyaert
fix: github idp - test length of the array before accessing the secon…
df784b5 
…d element

fixes gravitee-io/issues#5507
gcusnieux pushed a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Aug 3, 2021
@leleueri @gcusnieux
fix: github idp - test length of the array before accessing the secon…
5cb5084 
…d element

fixes gravitee-io/issues#5507
gcusnieux pushed a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Aug 3, 2021
@leleueri @gcusnieux
fix: github idp - test length of the array before accessing the secon…
d344a7f 
…d element

fixes gravitee-io/issues#5507
gcusnieux pushed a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Aug 3, 2021
@leleueri @gcusnieux
fix: github idp - test length of the array before accessing the secon…
783b45b 
…d element

fixes gravitee-io/issues#5507
gcusnieux pushed a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Aug 3, 2021
@leleueri @gcusnieux
fix: github idp - test length of the array before accessing the secon…
e83b6e7 
…d element

fixes gravitee-io/issues#5507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leleueri leleueri

Labels
project: APIM status: in review type: bug
Projects
None yet
Milestone
APIM - 3.5.18
Development

No branches or pull requests
4 participants
@NicolasGeraud @gcusnieux @leleueri @RachidKelidou