New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repository] Inconsistent requirements in repository unit tests - updating item that doesn't exist in the repo #641

Closed
Yaytay opened this Issue Jun 15, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@Yaytay

Yaytay commented Jun 15, 2017

The test for PageRepository expects an exception when asked to update a Page that doesn't exist (PageRepositoryTest.java line 153).
The test for ViewRepository expects a null return value when asked to update a View that doesn't exist (ViewRepositoryTest line 112).

The behaviour should be consistent.

@aelamrani aelamrani changed the title from Inconsistent requirements in repository unit tests - updating item that doesn't exist in the repo to [repository] Inconsistent requirements in repository unit tests - updating item that doesn't exist in the repo Jun 15, 2017

@aelamrani aelamrani added the type: bug label Jun 15, 2017

@aelamrani

This comment has been minimized.

Member

aelamrani commented Jun 15, 2017

👍
Moreover, we should add tests on other repositories on update when not exists...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment