New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gateway] [management-api] Have a PID file for Gravitee processes #681

Closed
blackillzone opened this Issue Jul 11, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@blackillzone

blackillzone commented Jul 11, 2017

Expected Behavior

It would be a quick and good feature to have a PID file once the service is started (for both management service and gateway service).

Current Behavior

No PID file.

Possible Solution

From here, I'm actually using systemd to handle Gravitee as a Linux service. There is an option for PID file, but it will only check the presence of an existing PID file, and remove it if it persist after a service stop. It will not create it.
So it should be in the start script as a java option (for example: -Dpidfile.path=/var/run/gravitee.pid). What do you think ?

Context

A PID file permit to quickly check the PID of the process with standard monitoring solution. We could say that's old but it's a standard things on Linux, to store process ID, and almost all monitoring scripts are using this to get the process ID, and hen check the availability of this process.

Your Environment

  • Version used: 1.6.1
  • Browser Name and version:
  • Operating System and version: CentOS 7.2
@NicolasGeraud

This comment has been minimized.

Member

NicolasGeraud commented Jul 11, 2017

hi @blackillzone ,
sounds good. pidfile path should also be configured in the gravitee.yml.

Do you want to implement it ?

brasseld added a commit to gravitee-io/gravitee-common that referenced this issue Jul 11, 2017

brasseld added a commit to gravitee-io/gravitee-gateway that referenced this issue Jul 11, 2017

brasseld added a commit to gravitee-io/gravitee-gateway that referenced this issue Jul 11, 2017

brasseld added a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Jul 11, 2017

@brasseld brasseld self-assigned this Jul 11, 2017

brasseld added a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Jul 11, 2017

brasseld added a commit to gravitee-io/gravitee-gateway that referenced this issue Jul 11, 2017

@brasseld brasseld added this to the 1.8.0 milestone Jul 11, 2017

@brasseld brasseld changed the title from [gateway/management] Have a PID file for Gravitee processes to [gateway] [management-api] Have a PID file for Gravitee processes Jul 11, 2017

NicolasGeraud added a commit to gravitee-io/gravitee-common that referenced this issue Jul 11, 2017

NicolasGeraud added a commit to gravitee-io/gravitee-gateway that referenced this issue Jul 11, 2017

NicolasGeraud added a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Jul 11, 2017

@blackillzone

This comment has been minimized.

blackillzone commented Jul 12, 2017

Great, I would like to, but you're too quick for me :).

And the idea to add it as a configuration variable inside the gravitee.yml is a good bonus, but not mandatory for us at the moment, if we already have, at least, one pid file available.

But it would be a welcome feature for next versions :).

Thanks for reactivity !

@brasseld

This comment has been minimized.

Member

brasseld commented Jul 12, 2017

Hi @blackillzone
Running gravitee component as a daemon: https://docs.gravitee.io/apim_installguide_gateway.html

SY !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment