New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[management] Bad template #721

Closed
NicolasGeraud opened this Issue Aug 9, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@NicolasGeraud
Member

NicolasGeraud commented Aug 9, 2017

Default Templates use the toString() method for different objects such as api, owner, ...

The result is an ugly email.

Your Environment

  • Version used: 1.8.3
@shoaibjdev

This comment has been minimized.

shoaibjdev commented Aug 17, 2017

True, have just encountered this bug while evaluating GraviteeIO for forthcoming project.

Your subscription to the API ApiEntity{id='c1351ee2-d26e-4d22-b51e-e2d26e5d229e', name='FS CustomerService', version='0.0.1', description='CBS Service for Customer Module', proxy=io.gravitee.definition.model.Proxy@5ba76b9d, paths={/loans/query/cif=io.gravitee.definition.model.Path@4c154069, /deposits/query/cif=io.gravitee.definition.model.Path@45be1f2f, /=io.gravitee.definition.model.Path@54ca68d0}, createdAt=Mon Aug 14 17:37:58 EAT 2017, updatedAt=Mon Aug 14 17:42:37 EAT 2017, visibility=PUBLIC, state=STARTED, primaryOwner=io.gravitee.management.model.PrimaryOwnerEntity@34d11a57, role=null, tags=[], view=null, group=null, metadata={}} with plan io.gravitee.management.model.PlanEntity@b5540426 has been approved.

@NicolasGeraud

This comment has been minimized.

Member

NicolasGeraud commented Aug 17, 2017

this is easy to fix on your template if you can't wait to the next release.

@shoaibjdev

This comment has been minimized.

shoaibjdev commented Aug 17, 2017

@NicolasGeraud - Have looked into templates but not sure for example subscriptionApproved.html what to change there. I presume the change is required in Management API project java classes. If it's doable by changing template, please guide.

subsriptionApproved.html

Your subscription to the API ${api} with plan ${plan} has been approved.

@NicolasGeraud NicolasGeraud self-assigned this Aug 17, 2017

@NicolasGeraud NicolasGeraud added this to the 1.9.0 milestone Aug 17, 2017

NicolasGeraud added a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Aug 17, 2017

NicolasGeraud added a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Aug 17, 2017

@NicolasGeraud

This comment has been minimized.

Member

NicolasGeraud commented Aug 18, 2017

@shoaibjdev as you can see in the pull request, the fix needs a new version of the management-api. Sorry.

We will schedule a maintenance release next week.

brasseld added a commit to gravitee-io/gravitee-management-rest-api that referenced this issue Aug 18, 2017

@brasseld brasseld modified the milestones: 1.8.4, 1.9.0 Aug 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment