New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gateway] Missing back-pressure handling #918

Closed
lbovet opened this Issue Dec 1, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@lbovet

lbovet commented Dec 1, 2017

Expected Behavior

Streaming big contents should impact the memory consumption in a controlled way.

Current Behavior

The flow of the request and response bodies is currently not controlled. If a backend or client is reading slowly, the internal buffering can lead to OutOfMemoryError.

Possible Solution

Add back-pressure methods to the WriteStream (gateway-api) and implement them for the ProxyConnection and VerxtHttpResponse delegating to the underlying Vert.x back-pressure methods.

Steps to Reproduce (for bugs)

Setup a slowly consuming client/backend and GET/PUT a multi-GB file through it.

Context

Have APIs supporting content delivery (typically as ZIP file) in a scalable way.

Your Environment

  • Version used: 1.11.4
  • Browser Name and version: netcat/curl piped into stdbuf and hexdump to simulate slow consumption
  • Operating System and version: Ubuntu 17.04

@lbovet lbovet changed the title from Missing back-pressure handling to [gateway] Missing back-pressure handling Dec 1, 2017

@brasseld

This comment has been minimized.

@brasseld brasseld closed this Dec 14, 2017

@NicolasGeraud NicolasGeraud added this to the 1.12.0 milestone Dec 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment