feat(Settings.Item): add the ability to hide item title #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogonkov
requested review from
BlackPoretsky,
DarkGenius,
Lunory and
kendoow
as code owners
Contributor
|
Preview is ready. |
Contributor
|
Playwright Test Component is ready. |
DarkGenius
reviewed
Nov 21, 2025
| @@ -1,7 +1,6 @@ | |||
| @use '~@gravity-ui/uikit/styles/mixins'; | |||
Contributor
Author
There was a problem hiding this comment.
To reduce amount of warnings about @import deprecation
DarkGenius
reviewed
Nov 21, 2025
src/components/Settings/Settings.tsx
Outdated
| renderTitleComponent = identity, | ||
| mode, | ||
| description, | ||
| showTitle = true, |
Collaborator
There was a problem hiding this comment.
Can we use the result of renderTitleComponent instead of creating a new prop?
Contributor
Author
There was a problem hiding this comment.
You mean when we return null from it?
ogonkov
force-pushed
the
feat/settings_item_column
branch
from
c85d980 to
600f4b7
Compare
ogonkov
force-pushed
the
feat/settings_item_column
branch
from
600f4b7 to
cb659ef
Compare
DarkGenius
approved these changes
Nov 21, 2025
DarkGenius
pushed a commit
that referenced
this pull request
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.