Skip to content

feat: add case-sensitive search #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 11, 2025
Merged

feat: add case-sensitive search #20

merged 12 commits into from
Nov 11, 2025

Conversation

@Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Nov 7, 2025

No description provided.

@Raubzeug Raubzeug requested a review from ma-efremoff as a code owner November 7, 2025 11:40
@gravity-ui-bot
Copy link
Contributor

gravity-ui-bot commented Nov 7, 2025

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

gravity-ui-bot commented Nov 7, 2025

Visual Tests Report is ready.

@ma-efremoff
Copy link
Collaborator

ma-efremoff commented Nov 7, 2025

Please add some screenshot tests for the options

@Raubzeug
Copy link
Contributor Author

Raubzeug commented Nov 7, 2025

Please add some screenshot tests for the options

It seems, it's not needed, case no changes in UI were made: it's just internal logic.

@Raubzeug Raubzeug force-pushed the add-case-sensitivity branch from 6bf564b to 93d2d39 Compare November 7, 2025 16:14
@ma-efremoff
Copy link
Collaborator

ma-efremoff commented Nov 8, 2025

It seems, it's not needed, case no changes in UI were made: it's just internal logic.

It is a good approach when we have appropriate tests for each storybook page.
Our tests check functionality of available features, so it is better to add some for these changes.

@ma-efremoff
Copy link
Collaborator

ma-efremoff commented Nov 11, 2025

The commit has changed default behavior of search feature, so we need to modify some existing tests.

@Raubzeug Raubzeug force-pushed the add-case-sensitivity branch from a8ae4ca to 9588e48 Compare November 11, 2025 11:36
@Raubzeug
Copy link
Contributor Author

Raubzeug commented Nov 11, 2025

The commit has changed default behavior of search feature, so we need to modify some existing tests.

I decided not to break default behavior, so the new property in caseInsensitiveSearch.

@Raubzeug Raubzeug merged commit c15e5c6 into main Nov 11, 2025
3 checks passed
@Raubzeug Raubzeug deleted the add-case-sensitivity branch November 11, 2025 13:02
@gravity-ui-bot gravity-ui-bot mentioned this pull request Nov 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ma-efremoff ma-efremoff ma-efremoff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Raubzeug @gravity-ui-bot @ma-efremoff