Skip to content
Permalink
Browse files

Drop leisure=common (#3619)

This PR drops rendering of leisure=common.

The leisure=common tag has several problems. I therefore think we should not render it on the default style.

Some of these problems are:

* The tag defines a legal ownership concept, not a physical concept. According to the [wiki](https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dcommon), a common is 'land which has an owner, but over which other people have certain rights'. I think we should render the physical appearance or purpose of features rather than their legal status.

* The tag is very UK centric. Commons are a UK concept that does not really translate to other countries.

* The tag is heavily misused. At least in Western Europe, almost all objects tagged with leisure=common are not actually commons. The tag is often used for random pieces of public grass, such as those alongside roads. The fact that the tag renders nicely green on the map probably has something to do with this.

* Other tags are available. Almost all areas that are currently tagged with leisure=common can also be tagged with other tags that are currently being rendered, such as leisure=park, landuse=grass and/or landuse=farmland.
  • Loading branch information...
matthijsmelissen committed Feb 12, 2019
1 parent 8a2f82b commit 4df96c4e4927c3e029b31e34c0cf1be2dda6f637
Showing with 7 additions and 10 deletions.
  1. +0 −2 amenity-points.mss
  2. +2 −3 landcover.mss
  3. +5 −5 project.mml
@@ -2385,7 +2385,6 @@
[feature = 'leisure_recreation_ground'],
[feature = 'landuse_recreation_ground'],
[feature = 'landuse_village_green'],
[feature = 'leisure_common'],
[feature = 'leisure_garden'],
[feature = 'landuse_quarry'],
[feature = 'landuse_vineyard'],
@@ -2464,7 +2463,6 @@
[feature = 'leisure_recreation_ground'],
[feature = 'landuse_recreation_ground'],
[feature = 'landuse_village_green'],
[feature = 'leisure_common'],
[feature = 'leisure_garden'] {
text-fill: @leisure-green;
}
@@ -1,6 +1,6 @@
// --- Parks, woods, other green things ---

@grass: #cdebb0; // Lch(90,32,128) also grassland, meadow, common, village_green, garden
@grass: #cdebb0; // Lch(90,32,128) also grassland, meadow, village_green, garden, allotments
@scrub: #c8d7ab; // Lch(84,24,122)
@forest: #add19e; // Lch(80,30,135)
@forest-text: #46673b; // Lch(40,30,135)
@@ -359,8 +359,7 @@
[feature = 'natural_grassland'][zoom >= 5],
[feature = 'landuse_meadow'][zoom >= 5],
[feature = 'landuse_grass'][zoom >= 10],
[feature = 'landuse_village_green'][zoom >= 10],
[feature = 'leisure_common'][zoom >= 10] {
[feature = 'landuse_village_green'][zoom >= 10] {
polygon-fill: @grass;
[way_pixels >= 4] { polygon-gamma: 0.75; }
[way_pixels >= 64] { polygon-gamma: 0.3; }
@@ -129,7 +129,7 @@ Layer:
'allotments', 'forest', 'farmyard', 'farmland', 'greenhouse_horticulture',
'recreation_ground', 'village_green', 'retail', 'industrial', 'railway', 'commercial',
'brownfield', 'landfill', 'construction', 'plant_nursery', 'religious') THEN landuse ELSE NULL END)) AS landuse,
('leisure_' || (CASE WHEN leisure IN ('swimming_pool', 'playground', 'park', 'recreation_ground', 'common', 'garden',
('leisure_' || (CASE WHEN leisure IN ('swimming_pool', 'playground', 'park', 'recreation_ground', 'garden',
'golf_course', 'miniature_golf', 'sports_centre', 'stadium', 'pitch', 'ice_rink',
'track', 'dog_park', 'fitness_station') THEN leisure ELSE NULL END)) AS leisure,
('man_made_' || (CASE WHEN man_made IN ('works', 'wastewater_plant', 'water_works') THEN man_made ELSE NULL END)) AS man_made,
@@ -1394,7 +1394,7 @@ Layer:
AND NOT tags @> 'capital=>yes'
OR (place IN ('suburb', 'quarter', 'neighbourhood', 'locality', 'isolated_dwelling', 'farm')
OR (place IN ('square')
AND (leisure is NULL OR NOT leisure IN ('park', 'common', 'recreation_ground', 'garden')))
AND (leisure is NULL OR NOT leisure IN ('park', 'recreation_ground', 'garden')))
) AND name IS NOT NULL
ORDER BY CASE
WHEN place = 'suburb' THEN 3
@@ -1934,7 +1934,7 @@ Layer:
AND (tunnel NOT IN ('yes', 'building_passage') OR tunnel IS NULL)
AND (covered NOT IN ('yes') OR covered IS NULL))
OR (place IN ('square')
AND (leisure IS NULL OR NOT leisure IN ('park', 'common', 'recreation_ground', 'garden')))
AND (leisure IS NULL OR NOT leisure IN ('park', 'recreation_ground', 'garden')))
AND name IS NOT NULL
ORDER BY way_area DESC
) AS roads_area_text_name
@@ -2126,7 +2126,7 @@ Layer:
WHEN shop IN ('no', 'vacant', 'closed', 'disused', 'empty') OR shop IS NULL THEN NULL ELSE 'other' END,
'office' || CASE WHEN tags->'office' IN ('no', 'vacant', 'closed', 'disused', 'empty') OR (tags->'office') IS NULL THEN NULL ELSE '' END,
'leisure_' || CASE WHEN leisure IN ('swimming_pool', 'water_park', 'miniature_golf', 'golf_course', 'fitness_centre', 'sports_centre', 'stadium', 'track',
'pitch', 'playground', 'park', 'recreation_ground', 'common', 'garden', 'nature_reserve', 'marina',
'pitch', 'playground', 'park', 'recreation_ground', 'garden', 'nature_reserve', 'marina',
'picnic_table', 'dog_park', 'fitness_station', 'firepit', 'sauna', 'beach_resort', 'bowling_alley',
'outdoor_seating', 'bird_hide', 'amusement_arcade', 'swimming_area', 'fishing', 'ice_rink') THEN leisure ELSE NULL END,
'power_' || CASE WHEN power IN ('plant', 'station', 'generator', 'sub_station', 'substation') THEN power ELSE NULL END,
@@ -2328,7 +2328,7 @@ Layer:
WHEN shop IN ('no', 'vacant', 'closed', 'disused', 'empty') OR shop IS NULL THEN NULL ELSE 'other' END,
'office' || CASE WHEN tags->'office' IN ('no', 'vacant', 'closed', 'disused', 'empty') OR (tags->'office') IS NULL THEN NULL ELSE '' END,
'leisure_' || CASE WHEN leisure IN ('swimming_pool', 'water_park', 'miniature_golf', 'golf_course', 'fitness_centre', 'sports_centre', 'stadium', 'track',
'pitch','playground', 'park', 'recreation_ground', 'common', 'garden', 'nature_reserve', 'marina',
'pitch','playground', 'park', 'recreation_ground', 'garden', 'nature_reserve', 'marina',
'slipway', 'picnic_table', 'dog_park', 'fitness_station', 'firepit', 'sauna', 'beach_resort', 'bowling_alley',
'outdoor_seating', 'bird_hide', 'amusement_arcade', 'swimming_area', 'fishing', 'ice_rink') THEN leisure ELSE NULL END,
'power_' || CASE WHEN power IN ('plant', 'station', 'generator', 'sub_station', 'substation') THEN power ELSE NULL END,

6 comments on commit 4df96c4

@mkyral

This comment has been minimized.

Copy link

replied Mar 4, 2019

Great. But not all areas with several trees are park. How to tag it? It's not a grass nor farmland. I think this is a sabotage from Pokémon players to have parks everywhere…

@matkoniecz

This comment has been minimized.

Copy link
Collaborator

replied Mar 4, 2019

I would be happy to answer that on tagging mailing list. Would it be OK for you to ask there?

(for multiple reasons it is preferable to not discuss "How to tag XYZ" here)

@Adamant36

This comment has been minimized.

Copy link
Contributor

replied Mar 4, 2019

"I think this is a sabotage from Pokémon players to have parks everywhere"

I agree with that. I'm constantly getting in arguements with Pokemon Go players because they tag things like their back yards as parks. Its the same with wooded type areas as you suggest. At one point I tried to get parks gwt better defined on the wiki, but it came to nothing "because cultural differences." I thought we were following the uk definition of things, but I guess people make exceptions when they don't feel like dealing with something and mainly use the "uk tagging preference" excuse as a way to chide people for not tagging things how they like. Oh wwell.I never took it to the mailing list though. I probably should have and that's what I suggest you do. Although its doubtful it will help any as its mostly the same people there as on the wiki that don't want to define it better already.

@mkyral

This comment has been minimized.

Copy link

replied Mar 5, 2019

I would be happy to answer that on tagging mailing list. Would it be OK for you to ask there?

(for multiple reasons it is preferable to not discuss "How to tag XYZ" here)

Done. Waiting for solution.

@Adamant36

This comment has been minimized.

Copy link
Contributor

replied Mar 5, 2019

@mkyral, do you have a link to the discussion? I'd like to follow along if possible.

Please sign in to comment.
You can’t perform that action at this time.