Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon for amenity=ice_cream #1479

Closed
seebk opened this issue Apr 12, 2015 · 21 comments
Closed

Icon for amenity=ice_cream #1479

seebk opened this issue Apr 12, 2015 · 21 comments

Comments

@seebk
Copy link

seebk commented Apr 12, 2015

amenity=ice_cream is curently not rendered in the map. Can this be changed?

@matkoniecz matkoniecz added this to the New features milestone Apr 12, 2015
@kocio-pl
Copy link
Collaborator

We should render it, since it's very popular (4 880 uses on taginfo), but we don't have the icon for it now for a start.

I wonder however if we should also render shop=ice_cream? It's far less used, but still almost thousand such tags exist in our database.

@dieterdreist
Copy link

2015-04-13 11:19 GMT+02:00 kocio-pl notifications@github.com:

We should render it, since it's very popular (4 880 uses on taginfo
http://taginfo.openstreetmap.org/tags/amenity=ice_cream), but we don't
have the icon for it now for a start.

I wonder however if we should also render shop=ice_cream? It's far less
used, but still almost thousand
http://taginfo.openstreetmap.org/tags/shop=ice_cream such tags exist in
our database.

similar to amenity=ice_cream there is also amenity=cafe (and maybe
amenity=fast_food) with cuisine=ice_cream (6836 uses currently:
http://taginfo.osm.org/tags/cuisine=ice_cream#overview ), but I am not sure
if we have the cuisine key currently. AFAIK this is not similar to
shop=ice_cream (which is AFAIK a take-away place and not a place with
seats).

@kocio-pl
Copy link
Collaborator

We could reuse the same icon with different standard color: brown for cafe, violet for shop/amenity. That would be simple and coherent for me.

Most probably we don't have cuisine key yet, but if we agree on that, it would be just a matter of time (i.e. database refresh).

@seebk
Copy link
Author

seebk commented Apr 14, 2015

I am no expert in icon design, but I wanted to give it a try:
https://cloud.sebastiankraft.net/index.php/s/9q1JQnpwzYSzCPS

If you like it feel free to use or modifiy it!

@seebk
Copy link
Author

seebk commented Apr 14, 2015

And here already is another one
http://osm-icons.org/wiki/File:12077.svg

@kocio-pl
Copy link
Collaborator

Could you try to rework it according to this draft? That would be more consistent with what we implement in OSM lately.

@sommerluk
Copy link
Collaborator

cuisine=* is currently not in the database.

I’m not sure if it’s a good idea to support three different taggings for (almost) the same thing. In any case, I think first of all the most common variant (cuisine=ice_cream) should get support – before maybe adding more variants later.

@dieterdreist
Copy link

2015-04-16 9:03 GMT+02:00 Lukas Sommer notifications@github.com:

I’m not sure if it’s a good idea to support three different taggings for
(almost) the same thing

at least shop=ice_cream (typically take away, no real seating possibility,
no table service) is different from amenity=cafe and cuisine=ice_cream
(table service, seating possibility) in a way similar than shop=alcohol to
amenity=pub. We also distinguish between a pub and a restaurant and a cafe,
so why wouldn't we want to make this distinction also for ice cream? Not
sure about amenity=ice_cream, could be both.

See these pictures for reference:
http://media.holidaycheck.com/data/urlaubsbilder/images/82/1156947037.jpg
(not sure if amenity=ice_cream or shop=ice_cream, but for sure its not a
cafe)
http://upload.wikimedia.org/wikipedia/de/thumb/1/17/Barchfeld_eisdiele.JPG/800px-Barchfeld_eisdiele.JPG
(amenity=cafe)
http://foodieinternational.com/wp-content/uploads/2012/04/IMG_4571-1024x681.jpg
(shop=ice_cream if there is no table service).

@sommerluk
Copy link
Collaborator

at least shop=ice_cream (typically take away, no real seating possibility,
no table service) is different from amenity=cafe

I understand the difference between a restaurant-like thing with tables and a simple take-away.

But the question is if these keys are really used according to this difference. The wiki page of amenity=ice_cream presents the cuisine=ice_cream version as an alternitive tagging with the same meaning. shop=ice_cream hasn’t it’s own wiki page – and what you can read at the wiki page of amenity=ice_cream about shop=ice_cream also doesn’t make a clear difference. Furthermore, the text “over the counter“ isn’t part of all translations. So I doubt that in practice mappers make a meaningfull difference between these three tagging variants.

I think it would be nice to have a clear distinction in the database, but I doubt that today this distinction is in the database.

@kocio-pl
Copy link
Collaborator

Would it do any bad to have alternative takes (if both are valid, of course)? I'm not sure rendering should prefer any tagging scheme in such cases.

@dieterdreist
Copy link

2015-04-16 12:04 GMT+02:00 Lukas Sommer notifications@github.com:

I understand the difference between a restaurant-like thing with tables
and a simple take-away.

But the question is if these keys are really used according to this
difference.

you can question this for every tag :-)

The wiki page of amenity=ice_cream presents the cuisine=ice_cream version
as an alternitive tagging with the same meaning. shop=ice_cream hasn’t it’s
own wiki page – and what you can read at the wiki page of amenity=ice_cream
about shop=ice_cream also doesn’t make a clear difference.

it's a wiki, you can change it.

Furthermore, the text “over the counter“ isn’t part of all translations.

"translations" are translations, the definition is on the English page.
Many translations for many tags are out of sync, I strongly encourage all
mappers to generally rely on the English version if possible (i.e. if they
understand it). The translations out of sync should be updated to the
content on the English page, but this is wishful thinking, I guess we are
lacking manpower.

So I doubt that in practice mappers make a meaningfull difference between
these three tagging variants.

I think it would be nice to have a clear distinction in the database, but
I doubt that today this distinction is in the database.

on which experience (country?) do you base this judgement? Maybe you can
write a message to their local mailing list and ask them to help cleaning
this up? Reducing what will get rendered will for sure not help to
differentiate the (in the real world existing) occurences.

FWIW, I have in a few occasions also used "sells:ice_cream=yes/industrial"
as an attribute for other places that also sell ice cream (like newspaper
agent, kiosk, convenience store, bar, ...)

@nebulon42
Copy link
Contributor

I could not resist to give it a try: https://github.com/nebulon42/osmic/blob/master/shop/ice-cream-14.svg

@kocio-pl
Copy link
Collaborator

Looks good for me.

@seebk
Copy link
Author

seebk commented Apr 16, 2015

Yes, that probably better fits the style of the other symbols. I would vote for using this icon for amenity=ice_cream as well as shop=ice_cream as described in the wiki.

@kocio-pl
Copy link
Collaborator

OK, so we have the icon and we have >5k such items in the database, so above any reasonable limit. I would also add shop=ice_cream (with shop color) which is currently only 931, because the difference is not clear for mappers and users. Should I prepare such PR?

@nebulon42
Copy link
Contributor

That would be great.

@dieterdreist
Copy link

sent from a phone

Am 24.06.2015 um 15:09 schrieb kocio-pl notifications@github.com:

OK, so we have the icon and we have >5k such items in the database, so above any reasonable limit. I would also add shop=ice_cream (with shop color) which is currently only 931, because the difference is not clear for mappers and users. Should I prepare such PR?

+1, when possible, cuisine=ice_cream (7185 objects) would be nice as well (rendered like amenity)

@nebulon42
Copy link
Contributor

Cusine is not in the rendering database yet, and would have to be dealt with later.

@kocio-pl
Copy link
Collaborator

Cuisine tag should be added to this issue probably to take effect.

BTW: does anybody knows what is the current state of preparation to database re-import? I asked there but no answer was given.

@HolgerJeromin
Copy link
Contributor

Cuisine tag should be added...

Not it should not
#1504 (comment)

@kocio-pl
Copy link
Collaborator

I still don't get the whole hstore thing, but that'd be nice. However I guess - this way or another - we still depend on database re-import and it's not clear when could it be and how far we are from this point, so cuisine=ice_cream rendering has to wait...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants