-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon for amenity=ice_cream #1479
Comments
|
We should render it, since it's very popular (4 880 uses on taginfo), but we don't have the icon for it now for a start. I wonder however if we should also render shop=ice_cream? It's far less used, but still almost thousand such tags exist in our database. |
|
2015-04-13 11:19 GMT+02:00 kocio-pl notifications@github.com:
similar to amenity=ice_cream there is also amenity=cafe (and maybe |
|
We could reuse the same icon with different standard color: brown for cafe, violet for shop/amenity. That would be simple and coherent for me. Most probably we don't have cuisine key yet, but if we agree on that, it would be just a matter of time (i.e. database refresh). |
|
I am no expert in icon design, but I wanted to give it a try: If you like it feel free to use or modifiy it! |
|
And here already is another one |
|
Could you try to rework it according to this draft? That would be more consistent with what we implement in OSM lately. |
|
cuisine=* is currently not in the database. I’m not sure if it’s a good idea to support three different taggings for (almost) the same thing. In any case, I think first of all the most common variant (cuisine=ice_cream) should get support – before maybe adding more variants later. |
|
2015-04-16 9:03 GMT+02:00 Lukas Sommer notifications@github.com:
at least shop=ice_cream (typically take away, no real seating possibility, See these pictures for reference: |
I understand the difference between a restaurant-like thing with tables and a simple take-away. But the question is if these keys are really used according to this difference. The wiki page of amenity=ice_cream presents the cuisine=ice_cream version as an alternitive tagging with the same meaning. shop=ice_cream hasn’t it’s own wiki page – and what you can read at the wiki page of amenity=ice_cream about shop=ice_cream also doesn’t make a clear difference. Furthermore, the text “over the counter“ isn’t part of all translations. So I doubt that in practice mappers make a meaningfull difference between these three tagging variants. I think it would be nice to have a clear distinction in the database, but I doubt that today this distinction is in the database. |
|
Would it do any bad to have alternative takes (if both are valid, of course)? I'm not sure rendering should prefer any tagging scheme in such cases. |
|
2015-04-16 12:04 GMT+02:00 Lukas Sommer notifications@github.com:
you can question this for every tag :-)
it's a wiki, you can change it.
"translations" are translations, the definition is on the English page.
on which experience (country?) do you base this judgement? Maybe you can FWIW, I have in a few occasions also used "sells:ice_cream=yes/industrial" |
|
I could not resist to give it a try: https://github.com/nebulon42/osmic/blob/master/shop/ice-cream-14.svg |
|
Looks good for me. |
|
Yes, that probably better fits the style of the other symbols. I would vote for using this icon for amenity=ice_cream as well as shop=ice_cream as described in the wiki. |
|
OK, so we have the icon and we have >5k such items in the database, so above any reasonable limit. I would also add shop=ice_cream (with shop color) which is currently only 931, because the difference is not clear for mappers and users. Should I prepare such PR? |
|
That would be great. |
|
sent from a phone
+1, when possible, cuisine=ice_cream (7185 objects) would be nice as well (rendered like amenity) |
|
Cusine is not in the rendering database yet, and would have to be dealt with later. |
|
Cuisine tag should be added to this issue probably to take effect. BTW: does anybody knows what is the current state of preparation to database re-import? I asked there but no answer was given. |
Not it should not |
|
I still don't get the whole hstore thing, but that'd be nice. However I guess - this way or another - we still depend on database re-import and it's not clear when could it be and how far we are from this point, so cuisine=ice_cream rendering has to wait... |
amenity=ice_cream is curently not rendered in the map. Can this be changed?
The text was updated successfully, but these errors were encountered: