Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render tower/mast nodes at different zoom levels according to height if present #2024

Closed
Penegal opened this issue Jan 18, 2016 · 3 comments
Closed

Comments

@Penegal
Copy link
Contributor

Penegal commented Jan 18, 2016

Hello, there.

I had an idea, but I don't know if it would be desirable or practical : the main use for communications masts and tower, IMHO, is for orientation in open field. Currently, the rendering of these features begins at the same zoom level, regardless of their height, but, for orientation purpose, a 300m tall tower is useful on a much wider area than a 25m tall one. Wouldn't it be great if the zoom level for rendering these was selected according to their height ? By making taller masts appearing at lower zoom levels than shorter ones, the displayed set of these objects would be more fitted to the use of the map at the different zoom levels.

I must add that I don't know or am not sure about the following criterias:

  • which tag combinations are currently displayed as a communication tower, as the modelling of these features is quite confusing to me;
  • if such differentiated rendering could be technically practical or would complexify rendering or code;
  • how to render them when their height wasn't modelled — at a default zoom level? at the lower one? the higher one?
  • if the height of these structures is given often enough for this differentiated rendering to be effective;
  • if this idea could be useful for other features like trees or peaks.

Hope this can help to improve the rendering.

Regards.

@dieterdreist
Copy link

2016-01-18 11:35 GMT+01:00 Penegal notifications@github.com:

I must add that I don't know or am not sure about the following criterias:

  • if such differentiated rendering could be technically practical or
    would complexify rendering or code;

any differentiation is augmenting complexity, here the main problem will
likely be units: while most of height data is likely entered in meters,
there are also a lot of values in feet or other units. E.g.
http://taginfo.osm.org/search?q=height%3Dft (another common notation is '
).

  • how to render them when their height wasn't modelled — at a default
    zoom level? at the lower one? the higher one?

the higher (number) one.

  • if the height of these structures is given often enough for this
    differentiated rendering to be effective;

the higher ones will likely already bear this information, and as soon as
we start interpretating it people will quickly add the missing ones.

  • if this idea could be useful for other features like trees or peaks

for trees there are other tags to explicitly state importance and for peaks
there are also other properties more relevant than absolute heights
(prominence and topographic isolation)

@pnorman pnorman added this to the 3.x - Needs upgrade to openstreetmap-carto.style milestone Jan 20, 2016
@Tomasz-W
Copy link

Tomasz-W commented Mar 8, 2018

Actualy, we have discussion about towers/masts and certain zooms in #2671 (comment)

So this issue should be closed as duplicate of #2556, or be referenced with "Resolves" line to #2671 (comment)

@kocio-pl ?

@kocio-pl
Copy link
Collaborator

kocio-pl commented Mar 8, 2018

Thanks for spotting these all tickets! I think we should continue where the real work is and this ticket is too general (it was open before I started working with actual code), so I referenced it with Resolves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants