Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider rendering indoor=room + shop/amenity better #2417

Closed
CloCkWeRX opened this issue Oct 23, 2016 · 7 comments

Comments

@CloCkWeRX
Copy link
Contributor

commented Oct 23, 2016

OpenLevelUp does a good job of rendering shopping malls and similar; but the default openstreetmap style doesn't do as well.

For example:
http://www.openstreetmap.org/#map=18/-27.38372/153.03169

Zoom 19, openstreetmap-carto
image

  • Good detail
  • Its not really clear how the shops are accessed, how big they are, etc

High zoom, openlevelup
image

  • Gives some idea of layout of shops
  • Better for navigating internally

Non free map; high zoom:
image

Zoom level 17:
image

  • Labels are dropped, but the food court is still very visually noisy

Zoom level 16:
image

  • Much cleaner visually

I'd be interesting in seeing what zoom level 17, indoor=* + amenity=fast_food or shop=* looked like if icons were replaced with the same "dot" for shop=yes; or a similar smaller icon:

Mockup:
image

At zoom level 18-19, it seems like a slightly lighter background color on indoor=* could be beneficial.

Mockup, please ignore the blue border/yellow boxes from JOSM:
image

@pnorman pnorman added this to the Database layout change milestone Oct 23, 2016
@mboeringa

This comment has been minimized.

Copy link

commented Oct 23, 2016

I think it very unwise to start rendering indoor room features in the main style. OpenLevelUp was specially designed for this, and is able to show features per level. In a pre-rendered style like Carto, you can not show multi-level building layout properly, everything will be stacked on top of each other.

While this particular single level shopping mall example might work reasonably in the mock-up, multi-level shopping malls with differing layout on levels, will become a mess in a pre-rendered style like Carto.

@matkoniecz

This comment has been minimized.

Copy link
Collaborator

commented Oct 23, 2016

Yes, it is rather typical that multilevel malls will have different store layouts on each level. So rendering shop areas is unlikely to work well.

@CloCkWeRX

This comment has been minimized.

Copy link
Contributor Author

commented Oct 23, 2016

everything will be stacked on top of each other.

What about the zoom level 16 behaviour that is currently there - thats already somewhat of a problem with the icons etc. What can be done to reduce that clutter?

@mboeringa

This comment has been minimized.

Copy link

commented Oct 23, 2016

What about the zoom level 16 behaviour that is currently there - thats already somewhat of a problem with the icons etc. What can be done to reduce that clutter?

My personal subjective opinion? ;-)

That would be that all shops belong at Z19/20... and even there they often collide with addresses, making the rendering of both impossible, so both renderings suffer: you neither see all addresses, nor all shops.

Even better would be a dynamic Overpass overlay that could be switched on / off at will, instead of as part of the rendering. But that would require changes to the main OpenStreetMap website...

@dieterdreist

This comment has been minimized.

Copy link

commented Oct 25, 2016

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

commented Nov 15, 2016

How should we select the default floor? I guess we can just avoid rendering shop/amenity with level tag present and different than 0.

However I'm not sure about side effects. Amenities and shops with level=* tag may be located in the underground passages (do we want them to still be visible or not?) and possibly in other places, not only in multi-level malls.

[EDIT] Related to #1977.

@matkoniecz

This comment has been minimized.

Copy link
Collaborator

commented Oct 16, 2017

I recommend closing this issue as it is unable to support malls with more than a single floor.

Showing only level=0 pois would break rendering in significant number of cases (underground passages, restaurants in basements, multilevel malls and as result encourage tagging for rendering by removing level tag) and would be quite strange - why show object at ground floor and not on upper floors?

@matkoniecz matkoniecz closed this Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.