Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering of intermittent streams broken #2633

Closed
matthijsmelissen opened this issue May 14, 2017 · 15 comments · Fixed by #2636

Comments

@matthijsmelissen
Copy link
Collaborator

commented May 14, 2017

Rendering of intermittent streams seems broken in master.

Screen shot:
screenshot_2017-05-14_22-58-37

@matthijsmelissen

This comment has been minimized.

Copy link
Collaborator Author

commented May 14, 2017

Did something go wrong with the hstore merge perhaps?

@imagico

This comment has been minimized.

Copy link
Collaborator

commented May 14, 2017

I don't think this is due to the hstore changes, i think this is caused by 970df74, specifically

https://github.com/gravitystorm/openstreetmap-carto/blame/master/water.mss#L195-L197

Side note: the water-lines code is quite difficult to understand meanwhile with all the tunnel/background/bridge stuff mixed fairly wildly.

@nebulon42 nebulon42 self-assigned this May 15, 2017

@nebulon42 nebulon42 added the bug label May 15, 2017

@pnorman pnorman added the regression label May 18, 2017

@pnorman

This comment has been minimized.

Copy link
Collaborator

commented May 18, 2017

Does this also impact 3.3.0?

@pnorman

This comment has been minimized.

Copy link
Collaborator

commented May 18, 2017

I don't think this is due to the hstore changes, i think this is caused by 970df74, specifically

https://github.com/gravitystorm/openstreetmap-carto/blame/master/water.mss#L195-L197

Yes, that looks like an error. some background/line-* properties are set, while background/line-color is unset except when int_tunnel = yes

nebulon42 added a commit to nebulon42/openstreetmap-carto that referenced this issue May 20, 2017
@nebulon42

This comment has been minimized.

Copy link
Contributor

commented May 20, 2017

Well spotted. This was somehow an leftover I have missed. This also impacts 3.3.0. I will cherry pick the commit to the 3.x branch once committed. As I have seen that 3.3.0 is now live we should probably release 3.3.1.

@boothym

This comment has been minimized.

Copy link
Contributor

commented May 20, 2017

I noticed something similar with a large black line on the map - is it related to this issue? https://www.openstreetmap.org/way/4301350 ok on z18/19 though

@andischan

This comment has been minimized.

Copy link

commented May 21, 2017

Have you stopped the z=12 rerendering because of this?
1faa5ada-f904-4802-9eda-f072c11a818c

nebulon42 added a commit to nebulon42/openstreetmap-carto that referenced this issue May 21, 2017
@nebulon42

This comment has been minimized.

Copy link
Contributor

commented May 21, 2017

@boothym Thanks for reporting this. It is now also fixed in #2636.
@andischan I'm not aware of anybody of us getting in touch with the sysadmins about this regression. So might be a tile server load or cache issue.

pnorman added a commit that referenced this issue May 22, 2017
remove leftover from background line for intermittent waterways and f…
…ix bridge drawing order, fixes #2633

(cherry picked from commit 102fb19)
giggls pushed a commit to giggls/openstreetmap-carto-de that referenced this issue May 24, 2017
remove leftover from background line for intermittent waterways and f…
…ix bridge drawing order, fixes gravitystorm#2633

(cherry picked from commit 102fb19)
@Robot8A

This comment has been minimized.

Copy link

commented May 28, 2017

It also happens in channel bridges: https://www.openstreetmap.org/#map=17/41.62288/-0.90528

@nebulon42

This comment has been minimized.

Copy link
Contributor

commented May 28, 2017

@Robot8A thanks, this was also fixed.

@andrewharvey

This comment has been minimized.

Copy link

commented Jun 16, 2017

Not sure if you're aware but this is still visible/an issue on osm.org, see the black lines which are intermittent streams:

image

https://www.openstreetmap.org/#map=13/-31.5630/159.0870

@imagico

This comment has been minimized.

Copy link
Collaborator

commented Jun 16, 2017

You have old tiles here - either browser cache or server side caching.

@andrewharvey

This comment has been minimized.

Copy link

commented Jun 16, 2017

You have old tiles here - either browser cache or server side caching.

No worries, I'll let it sort itself out over time then.

@naoliv

This comment has been minimized.

Copy link

commented Jun 18, 2017

New way https://www.openstreetmap.org/way/501481012 and it's still being rendered black: https://www.openstreetmap.org/#map=17/-28.96073/-52.65422

It can't be a cache issue with new data.

@HolgerJeromin

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2017

The fixed version of the style has not yet been rolled out. Just look when openstreetmap/chef#124 is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.