Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leisure=garden & leisure=park have the same colour #3022

Closed
DaveF63 opened this issue Jan 14, 2018 · 57 comments
Closed

leisure=garden & leisure=park have the same colour #3022

DaveF63 opened this issue Jan 14, 2018 · 57 comments

Comments

@DaveF63
Copy link

DaveF63 commented Jan 14, 2018

Public gardens are often sections within parks but atm there's no visible difference:
https://www.openstreetmap.org/way/191318876#map=19/51.45508/-2.58866

Slight darker shade or a boundary?

@SomeoneElseOSM
Copy link
Contributor

Example of what a "slightly darker shade" would look like: http://map.atownsend.org.uk/maps/map/map.html#zoom=19&lat=51.455193&lon=-2.589031 (different map style, but parks are the same colour, gardens different).

@DaveF63
Copy link
Author

DaveF63 commented Jan 14, 2018

Is my memory fading or is that the shade OSMCarto rendered gardens until recently?

@SomeoneElseOSM
Copy link
Contributor

It's certainly the shade that OSM Carto rendered gardens in 2014 - I haven't changed it since then.

@chrisfleming
Copy link
Contributor

chrisfleming commented Jan 14, 2018 via email

@Tomasz-W
Copy link

What do you think about pattern for garden areas: grass green shade with small colorful dots (symbol of flowers) added to it?

@kocio-pl kocio-pl added this to the Bugs and improvements milestone Jan 14, 2018
@DaveF63
Copy link
Author

DaveF63 commented Jan 14, 2018

What's preventing it returning to it's previous shade, which from memory was the same as @SomeoneElseOSM's current.

I'm not keen on patterned polygons. The translucence of footpaths makes it difficult to see within woods, even when zoomed in.

@matthijsmelissen
Copy link
Collaborator

What's preventing it returning to it's previous shade

Before, parks had the same color as grass, so areas of grass in parks were invisible.

@dieterdreist
Copy link

dieterdreist commented Jan 15, 2018 via email

@kocio-pl
Copy link
Collaborator

I have introduced this change in #2964.

The problem with garden is that it can be a lot of things - it can be:

  • basically a public or private park, were you can walk (kind of "Palace Garden" or "Botanical Garden"),
  • small decorative area in the public place (similar to flower bed, but filled with other plants)
  • private green area at the backyard of the house, which is not just a lawn (so called back garden),
  • kind of food garden (thus similar to farmland).

So it can be for leisure, decorative or food purposes (maybe some others too). With so much colors used already it's no longer the option to have separate color for every object type, some objects should be grouped. The garden has been clustered with grass areas, which I think is less similar than the park (grass only area vs different plants area).

@dieterdreist
Copy link

dieterdreist commented Jan 15, 2018 via email

@chrisfleming
Copy link
Contributor

chrisfleming commented Jan 15, 2018

FYI - I grabbed this screenshot when the changes to the garden colour rolled out. (The top is the new colour and the bottom half the old)

screenshot-2017-12-18 openstreetmap

My main issue is that I don't actually like the new colour and I do agree that we can't have a different colour for everything.

However I do like to be able to see the difference, partly because there are so many Pokemon go players changing Gardens to Parks, and also because I think it's good to see a difference between the largely public park areas's and the largely private gardens. And I think gardens can be summarised as cultivated in some ways and parks which are overall large grass areas.

@kocio-pl
Copy link
Collaborator

@dieterdreist Thanks, I was not aware of it! garden:type is being massively used (37k+), however we should look closer if it's clear enough and how should they be rendered then.

@kocio-pl
Copy link
Collaborator

Quick and dirty review:

  • botanical- very close to a park, so should be rendered the same as parks, so no change
  • residential - most of the time it will be probably "front yard/back garden", I'm not sure how should they be rendered like, but they are not for walking. But residence can be also a manor or palace and the garden can be more similar to park then.
  • community - I don't recognize this type at all just reading definition.
  • castle - definition not presented, probably something similar to manor/palace, but narrow - probably it would be good to have a single tag for all of them (or some hint should be added to wiki pages to simply tag them as parks).
  • monastery - most probably a food garden, but may have walking space - I don't know.

I guess park and big walkable gardens are similar, small residential gardens might be rendered different (how? just like the lawn?) and food garden, if we can identify it, might be rendered different (like a farmland maybe?).

@DaveF63
Copy link
Author

DaveF63 commented Jan 15, 2018

So it can be for leisure, decorative or food purposes (maybe some others too)...

Unless OSMCarto is using sub-tags to differentiate 'leisure=garden' I'm unsure how the multiple ways it's used in OSM is relevant. OSMCarto needs to ensure it doesn't clash with other entities it's gets added on top of.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jan 15, 2018

We are capable of using sub tags, so this is not a problem. Still we need to decide which ones are really useful and how should each type of garden be rendered. What are your propositions and remarks about garden:type for example?

There can be all the combinations - I have seen garden in the park, but also grass in the garden or park, I haven't seen garden in the grass area, but it's possible too... So I guess it won't help us to decide.

@dieterdreist
Copy link

dieterdreist commented Jan 15, 2018 via email

@kocio-pl
Copy link
Collaborator

no way, it is very different from a park (IMHO), it's a place of conservation and study, no leaving of the paths, etc.

In the parks I know leaving the paths is not allowed (I know UK might be different, but that's how it is in Poland). In general they are walkable and this is the main similarity. Botanical gardens in Warsaw I know are meant for public just like a park, this is not contradicting scientific use.

@dieterdreist
Copy link

dieterdreist commented Jan 15, 2018 via email

@DaveF63
Copy link
Author

DaveF63 commented Jan 15, 2018

Sorry, I didn't see your previous post until I sent my last one.
Unaware garden:type was in use. It would certainly help differentiate when overlaid.
botanical and residential would definitely be beneficial. I've tagged what described as community as allotments as they've been 'alloted' from public land & often have vegetables as well as flora.

The example I gave in my OP isn't really described.

From my experience:
botanical and community & the one in my OP need to be a different shade to park

residential won't coincide with park so could be the same shade if required

Here's a Google 360 of another example of a garden with a park:
http://tinyurl.com/y77u6h4w

@imagico
Copy link
Collaborator

imagico commented Jan 15, 2018

For better understanding:

  • leisure=park in OSM is an urban/near-urban area dedicated at a wide range of leisure/recreation activities (unless it is abused by some native English speakers for anything named park)
  • leisure=garden in OSM is for areas where gardening of some form is the primary purpose of the area - for mostly decorative, to a lesser extent scientific purposes or for small scale (individual household) consumption.

As usual i would suggest to look at:

  • the actual use of the tags in OSM (world wide and not just in your home town)
  • how other maps render parks and gardens (the distinction between those is not something OSM invented)

@dieterdreist
Copy link

dieterdreist commented Jan 15, 2018 via email

@kocio-pl
Copy link
Collaborator

@dieterdreist

In the parks I know cycling is also not allowed, some of them require fee and some are fenced.

However making the list "gardens vs parks" is not our ultimate goal - of course we may find differences between types, but the real problem is how should gardens be rendered? There will be always differences between objects in a "cluster", but we need to find patterns of similarities.

In other words: which clusters do you propose - and how should they be rendered?

@imagico

For better understanding:

This sounds like a clear difference, but I'm afraid it may be not very helpful. Gardening and leisure is where parks and gardens are similar in many cases (parks might not be about plants gardening, but I haven't seen it yet). And leisure is a common back garden purpose, just like food production, depending on the part of the world.

unless it is abused by some native English speakers for anything named park

Some "national parks" are good example (look at the California). However that seems to be true for gardens too, that's why I think big residential gardens (like "Royal Garden") might be just tagged as parks. And this is the same common problem in Polish.

As usual i would suggest to look at:

You're great at analysis, could you make such worldwide research? My research was not based only on my home town, but this is not what I do the best.

@dieterdreist
Copy link

dieterdreist commented Jan 15, 2018 via email

@matthijsmelissen
Copy link
Collaborator

Would giving gardens an outline solve this issue?

@kocio-pl
Copy link
Collaborator

It would make the small ones (like backyard gardens or flower-bed alike) look worse, so at least not in general.

@Tomasz-W
Copy link

Tomasz-W commented Jan 20, 2018

I've made few mock-ups in Photoshop (I'm unable to do a test rendering).
Grass green shade with colorful dots on it (click for full-size!)

Example1 (25%)
klasztor25
Example1 (50%)
klasztor50
Example2 (25%)
malta25
Example2 (50%)
malta50
Pattern (50%)
pattern50

Note, that it's very first version, just for show you the idea.

@kocio-pl
Copy link
Collaborator

Interesting, we could use some patterns (rather monochrome, I guess) with light green too. Maybe that would be good for all the gardens that are not similar to parks (which maybe should be just tagged like a park).

@kocio-pl
Copy link
Collaborator

This idea seems to be general enough - we don't need to look at garden subtypes, which are not that clear it seems, so I like it even more.

If we only add a note in the wiki to treat mainly "walkable" gardens as parks (not every park have to be garden with plants, but all the parks I know are in fact "walkable gardens"), no matter if the name includes Garden/Jardin/Ogród/... etc., that would be enough probably to render everything good.

@kocio-pl
Copy link
Collaborator

Well mapped botanical garden for testing how the new look will work with different types of sub-areas:

https://www.openstreetmap.org/way/26633037

@dieterdreist
Copy link

dieterdreist commented Jan 22, 2018 via email

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jan 22, 2018

The first one is interesting because it has an orchard inside.

The second one should have probably operator defined instead of amenity=university. But what are really these parts? - like that:

https://www.openstreetmap.org/way/226294581

Currently I think botanical gardens (leisure=garden + garden:type=botanical) might be the only gardens that should be rendered like a park.

@dieterdreist
Copy link

dieterdreist commented Jan 22, 2018 via email

@kocio-pl
Copy link
Collaborator

I tag the general campus this way, but not specific types of objects, for example garden of Warsaw University I tag as a garden (adding operator there would be good):

https://www.openstreetmap.org/way/5081150

I think this is the case when both tagging has its merits, so we can choose what looks better - it's not bad data. I would argue that operator has a bit more sense.

@dieterdreist
Copy link

dieterdreist commented Jan 22, 2018 via email

@kocio-pl
Copy link
Collaborator

I don't see any educational buildings there, so I wouldn't call it campus - just some garden which is university property (school can be owned by church, but I tag it as a school then). The same is true for BG of Warsaw University:

http://www.ogrod.uw.edu.pl/en

However I added university tag for the rest of the area, where there are no more specific landuse than just general university:

https://www.openstreetmap.org/way/25748407

But this is ambiguous question. The only important thing in this ticket is that in current state it probably won't work as a testbed for garden rendering.

@dieterdreist
Copy link

dieterdreist commented Jan 22, 2018 via email

@kocio-pl
Copy link
Collaborator

Another idea might be different shade of green, since we have a lot of them they work surprisingly well. One possible way might be to take green from camping site, which has different shade already, since we try to design outline for accommodation areas anyway (see #2290).

@Tomasz-W
Copy link

I've made new version of pattern with regular red and dark green dots:
pattern red

Examples (still just a Photoshop mock-ups, click for full-scale):
bloki
klasztor
malta
ue

@polarbearing
Copy link
Contributor

The red dots are a bit noisy for me, even if they are roses :-)

What about a shape, like a flower with petals flower1, rendered in a light-grey pattern such as forest trees?

@kocio-pl
Copy link
Collaborator

kocio-pl commented Feb 21, 2018

After some time off, I think now that we should use just another kind of green for gardens. They can be very different in size, access and purpose, for example:

  • big garden which is meant for walking -> probably better tagged as public park
  • botanical garden to walk (like a park), but also with special plants species to show/preserve/study, so like a public or private park
  • Japanese rock garden (zen garden), where the plants are just part of minimalistic decoration
  • monastery garden, which can be for growing vegetables (hence similar to farmland) or walking/contemplation (like private park)
  • residential garden, which can be big when being a part of a palace or manor (so a private park for walking), but also small - small backyard lawn with some trees, small front garden, which can be just a lawn, but also consist of some bushes, herbs and flowers
  • small patch of green plants (other than just grass) in the urban area, sometimes tagged as a village_green

Flower pattern is appropriate just for some forms of the garden, dots (colorful or just black in rows) might be good for more types, but they suggest growing plants (which sounds to me like most important feature of gardens in general), which might be not proper for zen garden (very few plants) or small residential garden (mainly grass).

So I guess we should use just another green shade, which is similar to grass, but maybe 10% lighter (or start with tourism=camp_site backbround, or maybe mix of grass and park colors), so we can show the structure if there are grass patches inside, but stay generic enough. We could also use dotted version as a generic pattern, so people will add more specific tags (type/style) which contain no dots - it's always better to have more specific tagging so generic values might have some annoyances/ambiguity.

What do you think about it?

@Tomasz-W
Copy link

We could also use dotted version as a generic pattern, so people will add more specific tags (type/style) which contain no dots

I like this idea. because most of gardens contains plants, so we should be more focused on them than on the less popular types.
What should be this pattern like then? What colours? With dots or some shape?

@kocio-pl
Copy link
Collaborator

I think black orchard pattern (with a different green shade in the background) would be good.

@Tomasz-W
Copy link

I don't like the idea of adding new shade of green, bacause I think we have them too much now, and adding next one will made mess even worst.

Look at this:
https://www.openstreetmap.org/#map=18/52.40511/16.97364
or this:
https://www.openstreetmap.org/#map=18/52.41408/16.93156

I think we shoud look for ways to reduce amount of green shades, not add new ones. That's the reason why I proposed dotted pattern with current grass-green background.
I also would like to distunguish grasses and meadows in the future, so make two patterns based on grass-green would be good solution here, I think, because all those vegetation areas (grasses, gardens, meadows) are on similar level (height).

@kocio-pl
Copy link
Collaborator

I'm quite surprised how well many shades of green work and how easy it's for me to recognize them. For me both examples work good.

Testing with grass color and orchard pattern looks OK for me for big areas and small patches of plants:
a4gamn0r
bvk2sji8
in uvomu
pu5jxsex

I was worried about small residential gardens, but that is also quite OK:
sbto5sxw

Orchard for comparison:
1b_nllh_

The only thing that would be not good probably are grass areas inside the garden. I haven't found such place, but this is similar one, where grass and garden are near each other:
50qkyk7w

@Tomasz-W
Copy link

Tomasz-W commented Feb 22, 2018

2 remarks:

@kocio-pl
Copy link
Collaborator

So let the others speak about the colors, please.

We use the crossed pattern for plant_nursery currently (which is also dark green, like an orchard):
46mgszgb

but if that's OK for the others, we can use this one instead - it is denser, so the difference with grass will be more visible:
pjgjjfpq
hkjjcmmq
96n6tv7s
fugmp8aw

@daganzdaanda
Copy link

IMHO the coloured patterns are drawing too much attention to themselves, even when the opacity is low.

I believe patterns should be used sparingly, and always be as subtle as possible, because they always raise the noise level. The plant-nursery pattern example is still too dark for my taste. It should have even less contrast to the background. Maybe 40% opacity is enough to make it visible but not irritating?

@kocio-pl
Copy link
Collaborator

Could you provide such file? I have problems with processing opacity.

@daganzdaanda
Copy link

The 40% was just a guess. I played with paint to come up with #A8C090 as a subtle colour for the pattern:
aa526

Can a pattern use black pixels and be set to have something like .4 or .25 opacity?

@kocio-pl
Copy link
Collaborator

I'm not sure, one has to check CartoCSS documentation or seek examples in our code.

@kocio-pl
Copy link
Collaborator

Thanks!

40% opacity real rendering examples:
gw3iv1d0
v9ew_f p

@Tomasz-W
Copy link

I like the previous '100%-version' more.

@kocio-pl
Copy link
Collaborator

I'm worried about small residential gardens to not look like a topographic map, so there are examples of different opacity - I vote for 60%:

40%
o5ivgrex

60%
allv y1p

80%
tvntupte

100%
wlknqdhr

@Tomasz-W
Copy link

I think 80% is visible good and not too noisy. Any other votes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants