Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private parking icon should have priority lower than normal parking icon #312

Closed
matkoniecz opened this issue Jan 13, 2014 · 17 comments

Comments

@matkoniecz
Copy link
Collaborator

commented Jan 13, 2014

http://www.openstreetmap.org/?mlat=50.0462&mlon=19.8828#map=15/50.0462/19.8828 displays private parking icon

blocking nearby parking icon - see http://www.openstreetmap.org/?mlat=50.0460&mlon=19.8824#map=16/50.0460/19.8824

IMHO private parking should not block rendering of normal parking icon as it is way less useful and important information

related to #70

@dieterdreist

This comment has been minimized.

Copy link

commented Jan 13, 2014

Am 13/gen/2014 um 10:34 schrieb Bulwersator notifications@github.com:

IMHO private parking should not block rendering of normal parking icon as it is way less useful and important information

+1, also Text and other icons are mostly more important than private parking icons

@CloCkWeRX

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2014

Important to point out:
Zoom level 15: Private parking is rendered
Zoom level 16: Both are rendered

@javbw

This comment has been minimized.

Copy link

commented Jan 14, 2014

yea, lvl 15 seems too far out for private parking.

You assume the supermarket has parking available, but you might need to know where the public parknride is around a freeway interchange. you probably need to find private parking in relation to the building(s), not the town - so lvl 15 is too far out. 16 would be better zoom level to start seeing Private parking show up (when the P would fit inside a parking lot)

@brycenesbitt

This comment has been minimized.

Copy link

commented Jan 14, 2014

+1 Beyond this, I think a different symbol is appropriate. Destination parking is only relevant to a person with a specific destination, to everyone else it is just a land use. Public parking however is someone one might seek.
I'd prefer to see private rendered in color only, and the P symbol used for public parking.

@matkoniecz

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 16, 2014

related issue: #287 (comment) (private parking icon is probably blocking display of university name)

@javbw

This comment has been minimized.

Copy link

commented Jan 17, 2014

Private parking should definitely be rendered at a much lower level than public parking.
(to me Parking=customers is "private")

Currently, both are bing rendered at lvl 15. I think Private parking should be moved to lvl 17.

here are some different sized parking lots -

lvl 15:
15
the private parking at the supermarket (besia) is rendered, as well as the parking for the hospital. the public parking at the station is not labeled because the gate has priority. (change to toll booth?)
a mislabeled public P in the south is shown. the P fits comfortably into the 200 spaces for the hospital, but the Ps dominate the view around the supermarket.

lvl 16
16
Public parking shows up at the train station, and the Ps for the hundred space parking fit nicely, but the 50 and the 6 space Ps are still pretty big. I'd rather have the McDonalds icon and besia fashion center labels still at this zoom level. The train Station's public parking shows up now.

lvl 17
17
everything fits, and the McDonalds parking disappears because of priority to the to the icon. The train station's other public parking shows up as well.

I think the public Ps showing up at 15 are okay, because "where is public parking" is useful at a wide zoom area.

I cannot think of a situation where I need to know where customer or private parking is at higher zoom levels, and it's rendering is visually cluttering and can be bothersome to any parking lot under 200 spaces at z15, and 100 spaces at z16.

I would prefer private parking (or at least access=customers) gets rendered in starting at zoom level 17.

@CloCkWeRX

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2014

@gravitystorm @pnorman - thoughts?

@Rovastar

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2014

I can't imagine they will want behaviour like this.

There is different behaviour in Carto to what it used to be like as there we had different shading of the P for normal, customer and private. Now (I presume since this carto style came out or it was changed ages ago) we just render normal (full colour P) and not normal (ligher P).

Technically it render the full colour P if access tag does not exist or access tag does not equal public or access tag does not equal 'yes' otherwise it will display the ligher P.

"CloCkWeRX commented 3 days ago

Important to point out:
Zoom level 15: Private parking is rendered
Zoom level 16: Both are rendered
"
That is not the case they are all rendered level 15 or higher.

I don't have a working machine with the database to test this fix I wrote but to have the same behaviour and just render non private at zoom 15 and both at zoom 16

amenity-points.mss replacing lines 166-172
//////////////////////////////////
[amenity = 'parking']::amenity {
[zoom >= 15] {
[access = ''][access = 'public'][access = 'yes'] {
point-file: url('symbols/parking.p.16.png');
point-placement: interior;
}
}
[zoom >= 16] {
point-file: url('symbols/parking.p.16.png');
point-placement: interior;
[access != ''][access != 'public'][access != 'yes'] {
point-file: url('symbols/parking_private.p.16.png');
}
}
}
//////////////////////////////////

Rovastar added a commit to Rovastar/openstreetmap-carto that referenced this issue Jan 17, 2014
fix private parking icons at wrong zoom i312
gravitystorm#312
I am pretty sure that is right but cannot test atm.
@javbw

This comment has been minimized.

Copy link

commented Jan 17, 2014

Thanks for the code Rovastar. I can always make a different icon for P if you want (at least I can try). Is making icons part of -carto, or is that some whole separate thing?

the current private P looks good for the customers - would an even more transparent P work for access != private;no ?

@matkoniecz

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 17, 2014

@Rovastar

""CloCkWeRX commented 3 days ago

Important to point out:
Zoom level 15: Private parking is rendered
Zoom level 16: Both are rendered
"
That is not the case they are all rendered level 15 or higher."

In this case only one is rendered, as two symbols are too close to render both - see links in original report.

@brycenesbitt

This comment has been minimized.

Copy link

commented Jan 17, 2014

While I think mappers should continue to tag private parking for stores and such,
I think the visual utility is in showing public parking. That's what you might scan a map for.
Perhaps private could come in at zoom 18 or 19.

@Theodin

This comment has been minimized.

Copy link

commented Jul 3, 2014

I second pushing private parking to z17 or 18, but it depends a little on what people tag. Parking in front of a mall could be only for customers, mainly for customers or for everyone in the area.
So if I am looking where to park while shopping in a certain supermarket, I might have to look for a public or a private parking lot.

@javbw

This comment has been minimized.

Copy link

commented Jul 3, 2014

Mall parking should be tagged customers. The employee parking in the back with the service docks would be private, and having it render at a higher zoom level than customers would be correct.

On Jul 3, 2014, at 4:05 PM, Theodin notifications@github.com wrote:

I second pushing private parking to z17 or 18, but it depends a little on what people tag. Parking in front of a mall could be only for customers, mainly for customers or for everyone in the area.
So if I am looking where to park while shopping in a certain supermarket, I might have to look for a public or a private parking lot.


Reply to this email directly or view it on GitHub.

@brycenesbitt

This comment has been minimized.

Copy link

commented Jul 3, 2014

From a cartography point of view, the map should show the explicitly public parking first. That's clearly a place to direct people to: they can learn which malls don't enforce parking rules later :-).

@matkoniecz matkoniecz self-assigned this Oct 30, 2014

@matkoniecz

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 5, 2015

I think that after other changes related to parking icons it is no longer a problem. Solving it would just add more complexity to style that is not currently necessary.

@matkoniecz matkoniecz removed their assignment Jul 5, 2015

@matthijsmelissen

This comment has been minimized.

Copy link
Collaborator

commented Jul 5, 2015

+1

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

commented Jul 5, 2015

BTW: as already mentioned in a different issue, I guess maybe for showing not-public parking icon we should rather use the code like:

    [access != null][access != 'yes'] {
      marker-opacity: 0.33;
    }

because "access=public" is defined just for toilets and it's not sure if we should use [access != ''] syntax?

[EDIT:] I guess this is new issue now for resolving this problem.

@pnorman pnorman added the wontfix label Aug 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.