Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render tower:type=communication (always) #339

Closed
jaakkoh opened this issue Feb 14, 2014 · 8 comments
Closed

Render tower:type=communication (always) #339

jaakkoh opened this issue Feb 14, 2014 · 8 comments

Comments

@jaakkoh
Copy link

jaakkoh commented Feb 14, 2014

This relates (at least in part) to Issue #181. In fact, my comment to it explains to whole thing - just wanted to open a separate issue for this in case as rendering of man_made=tower could mean different things, too:

"if there's a tower:type=communication in conjunction with man_made=mast then that icon is shown in OSM Mapnik (example: http://www.openstreetmap.org/node/2666366790).

I think this same rendering should happen when using man_made=tower (with tower:type=communication), which currently doesn't (http://www.openstreetmap.org/node/2489765793)."

@matkoniecz
Copy link
Contributor

@math1985

#1366 (comment)

I have asked the Dutch community to change their tagging scheme.

Is there any result? Or is the tagging situation still at state that makes data unusable?

@matthijsmelissen
Copy link
Collaborator

Is there any result? Or is the tagging situation still at state that makes data unusable?

No result yet, I made a new call to the Dutch community.

@martinum4
Copy link

so, any results jet? what makes the rendering of tower:type=communication (or man_made=tower if you don't want to render the other one) impossible?

@PontiacCZ
Copy link

Still no change? man_made=mast, tower:type=communication apparently used to be rendered, The Wiki shows us which icon was used for this object. Most likely someone just made a mistake when editing the stylesheets. What does take so long to fix it?

There is a man_made=tower, tower:type=communication tagged on a single node here but it's not rendered.

Less important masts get rendered without problems.

@kocio-pl
Copy link
Collaborator

@math1985 Are you still trying to discuss or is it time to decide? The PR should be rather easy to make.

@boothym
Copy link
Contributor

boothym commented Dec 1, 2016

This really needs to be sorted out. I'm amazed that a tag with 35,000 uses gets rendered (even though they might not be used for communication), but the tower:type=communication tag with almost 100,000 uses is ignored.

If there's a problem with incorrect tagging in one country that's a data problem and no reason not to render the tag elsewhere.

@kocio-pl
Copy link
Collaborator

One problem is deciding, the other is purely technical - does tower:type=* tag need database reload and what notation should be used in project.mml and in amenity-points.mss (colon is not typical part of tag)?

There's also very similar tag, which should be rendered the same way, probably on z16+, since it's for large structure - man_made=communications_tower (almost 4k uses).

@Tomasz-W
Copy link

I think this issue shoud be closed and further discussion should move to #2556.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants