Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for tourism=apartment #401

Closed
nounours77 opened this Issue Mar 13, 2014 · 71 comments

Comments

Projects
None yet
@nounours77
Copy link

commented Mar 13, 2014

Hello,

there is a new key tourism=apartment. Which is similar to tourism=chalet, but likely to be in more crowded areas. I suggest to render it with the same symbol as tourism=chalet, but starting at lower zoom-level.

thanks, nounours77

@matthijsmelissen matthijsmelissen added this to the New features milestone Aug 18, 2014

@matthijsmelissen matthijsmelissen changed the title Render tourism=apartment Add rendering for tourism=apartment Sep 24, 2014

@matkoniecz

This comment has been minimized.

Copy link
Collaborator

commented Jul 5, 2015

I think that it would be overkill. Such features are not too important and in some areas it would result in a really bad rendering - there are towns where nearly every house rent apartments. airbnb and similar are making situation significantly worse for such rendering.

I propose closing this request.

@pnorman

This comment has been minimized.

Copy link
Collaborator

commented Jul 5, 2015

Usage is also fairly low

@pnorman

This comment has been minimized.

Copy link
Collaborator

commented Aug 15, 2016

I still find the low usage (2.8k) is a concern. I also don't find it as relevant as other tourism features for a general purpose map. A large part of this is relative insignificance on the ground.

Downtown Vancouver has many apartments to rent
image

I doubt you could see any of these if you were there in person. They'd be unsigned, even inside the building.

@geowOSM

This comment has been minimized.

Copy link

commented Aug 16, 2016

tourism=apartment are particularly popular and important in Austria, Germany, Switzerland and parts of northern Italy, but are widely distributed throughout Europe and the world. https://taginfo.openstreetmap.org/tags/tourism=apartment#map

The current usage of tourism=apartment is relatively low, because mappers are massively inclined to use descriptive names and misuse tourism=chalet instead to get holiday apartments rendered.

Examples from Austria and Italy/South Tyrol
("Ferienwohnung" means holiday apartment)
http://www.openstreetmap.org/#map=19/47.64739/12.20317&layers=N
osm_apartment_2016-08-16 um 09 49 44

http://www.openstreetmap.org/#map=18/46.68174/11.07463&layers=N
osm_apartment_it_2016-08-16 um 10 03 46

The number of the actually existing tourism=apartment are significantly higher than the low usage might imply on first sight. And to my experience they are almost always visible on spot due to outdoor advertising.

I would suggest to render tourism=apartment with the same symbol as tourism=chalet, but starting at a lower zoom-level.

Thanks
geow

@tyrasd

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2016

I still find the low usage (2.8k) is a concern.

Even though the total numbers seem relatively low, mapping of this feature seems to be quite active and anything from stale:

taghistory 6

(edit: update the graph to include recently added objects)
(edit2: update the graph again)

@aceman444

This comment has been minimized.

Copy link

commented Sep 5, 2016

Yes, this type of accommodation are also popular e.g. in Croatian places along the seashore, where every other house may rent some apartments (even most of a house may be designated for apartment rentals). They often have names (of the house/villa) and outdoor advertising, so they are visible on the spot. Rendering them would be useful.

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

commented Sep 24, 2016

I suggest to render it with the same symbol as tourism=chalet, but starting at lower zoom-level.

I like this suggestion - what about z18 for example?

@geowOSM

This comment has been minimized.

Copy link

commented Sep 24, 2016

@kocio-pl z18 would be fine!

@pnorman

This comment has been minimized.

Copy link
Collaborator

commented Sep 26, 2016

I stayed at a tourism=apartment this SOTM, and I still believe it is something we shouldn't render. The visibility on the ground is very limited, so it doesn't help you with orientation. A specific apartment is unlikely to be a feature you are going to in an area because they have limited size.

@dieterdreist

This comment has been minimized.

Copy link

commented Sep 26, 2016

sent from a phone

Il giorno 26 set 2016, alle ore 10:36, Paul Norman notifications@github.com ha scritto:

I stayed at a tourism=apartment this SOTM, and I still believe it is something we shouldn't render. The visibility on the ground is very limited, so it doesn't help you with orientation. A specific apartment is unlikely to be a feature you are going to in an area because they have limited size.

yes, it depends;-)
There are nowadays a lot of "invisible" tourist apartments (airbnb, booking etc), and there are apartments with hotel-like signage (i.e. very prominent, especially in remote areas they might be the most significant feature), sometimes even offered by actual hotels (the latter case is not interesting either, because we would already show the hotel).

@pnorman

This comment has been minimized.

Copy link
Collaborator

commented Sep 29, 2016

After reviewing the additional discussion I think the original decision to decline remains the right one.

@tyrasd

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2017

@pnorman could you please reiterate what the original decision was actually based on?

In my opinion, I think that most (or all?) of the early arguments against rendering these objects have been falsified: For example the low usage numbers (see updated graph in #401 (comment)).

Also, I haven't seen any example of where:

it would result in a really bad rendering [because of too high density of markers]

As far as I can see, the tourism=apartment tag is currently not really used to map airbnb-style apartments, but much more often for "serious" tourism businesses (which typically do have a name/sign on the building, own websites, proper contact information, etc.). Actually, I think that it would not even make sense to map unsigned (even inside the building) apartments-for-rent, because that would simply be against OSM's on-the-ground verifiability rule!?

I find the current situation very annoying where people continue to actively misuse other tags such as tourism=guest_house to map this kind of tourism businesses (because the proper tag is not rendered on the map).

@dieterdreist

This comment has been minimized.

Copy link

commented Mar 5, 2017

@tyrasd

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2017

…but if it's not signed, you cannot find out if there actually is a tourism apartment or not (except for checking on the airbnb website which is of course no viable source for OSM). One mapper might have stayed at such an "invisible" apartment, but others cannot verify it on the ground -> ergo it should not be mapped. Isn't that one of the basic working rules for mapping?

edit: See http://wiki.openstreetmap.org/wiki/How_We_Map:

Contributions to OpenStreetmap should be: […] Verifiable - means that others can go there and see for themselves if your data is correct.

@geowOSM

This comment has been minimized.

Copy link

commented Mar 5, 2017

In my opinion, I think that most (or all?) of the early arguments against rendering these objects have been falsified: For example the low usage numbers (see updated graph in #401 (comment)).

+1 According to taginfo by today there are 5.4 k occurrences in the db.

Both of the main editors (iD and JOSM) provide presets for tourism=apartment.

I find the current situation very annoying where people continue to actively misuse other tags such as tourism=guest_house

+1 Another misused tag to get it rendered is tourism=chalet, like here

So I would deeply like to ask for rendering!

Thanks for considering
geow

@dieterdreist

This comment has been minimized.

Copy link

commented Mar 5, 2017

@polarbearing

This comment has been minimized.

Copy link
Contributor

commented Jan 12, 2018

this way you can show an svg icon from a repository here inline:
<img src="https://cdn.rawgit.com/gravitystorm/openstreetmap-carto/master/symbols/hotel.svg">
So the JOSM icon is: which is hard to recognise.

What about my proposal with the two grey lines image ? Not fully self-explanatory, but neither are chalet nor guest house.

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

commented Jan 12, 2018

Thanks, didn't know this! You're right, JOSM was used just as a proof that somebody else thought about using part of the building too.

If window in the background won't work, rendering guest house would be still preferable for me (with z18+ instead of z17+), because this would give us a benefit of "similar but smaller" association.

BTW: your design reminds me that we could make hospital to be more neutral - mirrored red bed in the circle might work.

@geowOSM

This comment has been minimized.

Copy link

commented Jan 12, 2018

@polarbearing wrote
@geowOSM - Sarcasm does not help to solve the issue.

Sorry, it's not meant sarcastic or arrogant, but there is a serious point. Apparently the participants in this thread are not graphic designers. My intention was to suggest that we seek some assistance from outside.

@polarbearing

This comment has been minimized.

Copy link
Contributor

commented Jan 12, 2018

I'd be not happy with the same icon for guest house and apartment, since the service concept is different. In the guest house you typically get breakfast and room service (just not full hotel attendance), while in the apartment you are on your own once you get the key.
Hm, key... what about a bed and a grey key in the background?
1
2
3
4 hotel bed with key from rental_bicycle (mirrored)

(grabbing the raw gist URL and replacing gist.githubusercontent.com with cdn.rawgit.com in the img tag)

Bed in circle for hospital becomes tricky since scaling the bed down it spoils the pixel alignment:

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

commented Jan 12, 2018

I'd be not happy with the same icon for guest house and apartment, since the service concept is different.

Sure, it's my second choice exactly because they are not the same. However they are similar and if we have no better idea, making a difference by zoom level is still enough for me.

Hm, key... what about a bed and a grey key in the background?

Yes, that sounds good to me! We would still have house vs room (house vs key) analogy plus we already have a small key element tested and used (bicycle station for example - "renting a bed" also sounds like plausible analogy 😄), so designing this icon should be easy.

@matkoniecz

This comment has been minimized.

Copy link
Collaborator

commented Jan 12, 2018

@geowOSM

My intention was to suggest that we seek some assistance from outside.

AFAIK we asked some time ago on mailing list and nobody was interested. If somebody has a good how to encourage people to contribute icons it can be done (or discussed in a separate issue if it involves some changes to a project).

@polarbearing

This comment has been minimized.

Copy link
Contributor

commented Jan 12, 2018

Added the bicycle key to the drafts above (4) - my favourite so far. The SVGs are in my gist.

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

commented Jan 12, 2018

Thanks, 4 is exactly what I have envisioned for z18+! Could you prepare a PR with it?

@geowOSM

This comment has been minimized.

Copy link

commented Jan 12, 2018

If somebody has a good how to encourage people to contribute icons it can be done

If you agree I would like to submit the topic for the next weeklyOSM.

@matkoniecz

This comment has been minimized.

Copy link
Collaborator

commented Jan 12, 2018

If you agree I would like to submit the topic for the next weeklyOSM.

Good idea, it is better than posting to mailing list (that feels spammy for me to keep doing it again and again) and there is chance that somebody relevant will read it.

In general any feedback is useful (except "why it is not yet implemented" comments or people posting "+1" instead of using reaction feature).

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

commented Jan 12, 2018

I guess we need both icon designers and code newbies (osm-carto is specific project, so even if one knows SQL and git, there's still CartoCSS, cartographic POV and local conventions). There are tons of issues that can be fixed with a little guidance from maintainers mainly by extending/fixing current code, but even small feature takes some time and focus usually and I can't handle more than few of them at once, for example.

Unfortunately there was no response from new people when I asked lately on Talk list if anyone is willing to join us and learn the basics. So we're still looking.

@polarbearing

This comment has been minimized.

Copy link
Contributor

commented Jan 12, 2018

Should do, probably, so the skills don't get rusty.
Does it make sense to create a new directory under symbols to tidy up? There is shop already, so we could either use tourism or more specifically accommodation?

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

commented Jan 12, 2018

I guess tidying should be separate (and simple) ticket.

@dieterdreist

This comment has been minimized.

Copy link

commented Jan 13, 2018

@geowOSM

This comment has been minimized.

Copy link

commented Jan 13, 2018

If you agree I would like to submit the topic for the next weeklyOSM.

Got feedback, it's scheduled for the next edition (391).

@polarbearing

This comment has been minimized.

Copy link
Contributor

commented Jan 13, 2018

@dieterdreist - which one works better for you, the

image two grey lines or
4, hotel bed with key from rental_bicycle (mirrored) ?

I spent last night setting up docker/kosmtik, was expecting this a bit more lightweight than it comes.

@geowOSM

This comment has been minimized.

Copy link

commented Jan 13, 2018

@polarbearing

For me the key in 4 is too vague/unspecific as most forms of accommodation provide you a key.

I like the "bed with two grey lines" for its simplicity, resembling a room or flat.

@dieterdreist

This comment has been minimized.

Copy link

commented Jan 13, 2018

@polarbearing

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2018

z19_apartment_choice2

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

commented Jan 14, 2018

Key version is more readable for me.

@polarbearing

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2018

Any more votes? Looks like a draw currently:
Key @kocio-pl @polarbearing
Box @dieterdreist @geowOSM

@nounours77

This comment has been minimized.

Copy link
Author

commented Jan 16, 2018

Box +1

@HolgerJeromin

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2018

+1 for Light box (right). the dark box is too heavy

@gc-web

This comment has been minimized.

Copy link

commented Jan 17, 2018

+1 for light box right

@my-na-me

This comment has been minimized.

Copy link

commented Jan 17, 2018

Thanks all for following up this ticket, for new fresh ideas and for nice preview picture.

+1 for all three proposals (bed with light box, bed with dark box and bed with key icon)

If I should tell my preferred order of these 3 options, it looks like:

  1. key (because for apartment it is more usual that you hold the key for the whole time of rent in your pocket/responsibility. If I'm living in a hotel room, I tend to give the key daily back to reception, for example that they know the daily room cleaning is welcome)
  2. light box
  3. dark box
@polarbearing

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2018

Yes the reasons you name for the key version were what I thought as well. Anyway there were more votes for the box version, which also symbolises the situation well, thus why I made the PR with that icon.
@kocio-pl - anything else to do?

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

commented Jan 18, 2018

Since PR is ready, somebody needs to look at the code and test it, so now it's work for repo maintainers.

@matkoniecz

This comment has been minimized.

Copy link
Collaborator

commented Jan 20, 2018

For potential visitors from WeeklyOSM: rendering is added in #3024 - but if anybody has idea for a new, better icon of this object or any other - please open a new issue ( https://github.com/gravitystorm/openstreetmap-carto/issues/new )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.